Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: storedSessions get returns object not string #5727

Merged
merged 5 commits into from
May 16, 2021
Merged

fix: storedSessions get returns object not string #5727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b0e404
fix: storedSessions get returns object not string
cameronbraid May 15, 2021
85c8815
Apply suggestions from code review
timleslie May 16, 2021
f4fab35
Create poor-bears-remember.md
timleslie May 16, 2021
b545a21
Merge branch 'master' into stored-session-fix-data
timleslie May 16, 2021
93ece0c
Apply suggestions from code review
timleslie May 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/poor-bears-remember.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@keystone-next/keystone": patch
---

Fixed a bug in `storedSessions` not correctly identifying the current `sessionId`.
6 changes: 4 additions & 2 deletions packages-next/keystone/src/session/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,8 @@ export function storedSessions({
let isConnected = false;
return {
async get({ req, createContext }) {
let sessionId = await get({ req, createContext });
const data = (await get({ req, createContext })) as { sessionId: string } | undefined;
const sessionId = data?.sessionId;
if (typeof sessionId === 'string') {
if (!isConnected) {
await store.connect?.();
Expand All @@ -207,7 +208,8 @@ export function storedSessions({
return start?.({ res, data: { sessionId }, createContext }) || '';
},
async end({ req, res, createContext }) {
let sessionId = await get({ req, createContext });
const data = (await get({ req, createContext })) as { sessionId: string } | undefined;
const sessionId = data?.sessionId;
if (typeof sessionId === 'string') {
if (!isConnected) {
await store.connect?.();
Expand Down