Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New core #5665

Merged
merged 320 commits into from
Jun 8, 2021
Merged

New core #5665

merged 320 commits into from
Jun 8, 2021

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented May 10, 2021

This is a re-implemention of the core of Keystone and all the server-side parts of field types. The original intent was to land this along with all the changes mentioned in #5635 but to make this easier to land, we've instead made this only contain architectural changes (+ some minimal coupled breaking changes for practicality). We'll land the other changes mentioned #5635 in future PRs.

@changeset-bot
Copy link

changeset-bot bot commented May 10, 2021

🦋 Changeset detected

Latest commit: 420c025

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@keystone-next/keystone Major
@keystone-next/fields Major
@keystone-next/auth Major
@keystone-next/cloudinary Major
@keystone-next/fields-document Major
@keystone-next/types Major
@keystone-next/test-utils-legacy Patch
@keystone-next/benchmarks-legacy Patch
@keystone-next/example-blog Patch
@keystone-next/example-default-values Patch
@keystone-next/example-extend-graphql-schema Patch
@keystone-next/example-json-field Patch
@keystone-next/example-task-manager Patch
@keystone-next/example-with-auth Patch
@keystone-next/example-assets-cloud Patch
@keystone-next/example-assets-local Patch
@keystone-next/example-auth Patch
@keystone-next/examples-app-basic Patch
@keystone-next/example-ecommerce Patch
@keystone-next/example-embedded-nextjs Patch
keystone-next-app Patch
@keystone-next/example-roles Patch
@keystone-next/example-sandbox Patch
@keystone-next/website Patch
@keystone-next/utils-legacy Patch
@keystone-next/api-tests-legacy Patch
@keystone-next/admin-ui-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/4bcG7wJLiMQ8LWUbyhoNMhf7D94G
✅ Preview: https://keystone-next-docs-git-next-fields-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview May 11, 2021 00:38 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 00:42 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 00:45 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 01:19 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 01:21 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 01:23 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 01:26 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 01:29 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 02:14 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 02:37 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 02:51 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 02:56 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 03:40 Inactive
emmatown and others added 2 commits May 11, 2021 15:28
* Add tests for uniqueness

* Update packages-next/fields/src/types/timestamp/index.ts

Co-authored-by: Mitchell Hamilton <mitchell@hamil.town>
@vercel vercel bot temporarily deployed to Preview May 11, 2021 05:29 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 05:31 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 06:04 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 06:10 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 06:12 Inactive
@vercel vercel bot temporarily deployed to Preview May 11, 2021 06:38 Inactive
@timleslie timleslie mentioned this pull request May 11, 2021
@vercel vercel bot temporarily deployed to Preview June 8, 2021 02:35 Inactive
@emmatown emmatown requested review from timleslie and removed request for timleslie June 8, 2021 02:56
@vercel vercel bot temporarily deployed to Preview June 8, 2021 04:13 Inactive
Co-authored-by: Tim Leslie <timl@thinkmill.com.au>
@vercel vercel bot temporarily deployed to Preview June 8, 2021 05:06 Inactive
@emmatown emmatown requested a review from timleslie June 8, 2021 05:17
/**
* The label used for the list
* @default listKey.replace(/([a-z])([A-Z])/g, '$1 $2').split(/\s|_|\-/).filter(i => i).map(upcase).join(' ');
*/
// Not currently supported
// label?: string;
label?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we support these new config options now? If so we should make sure these are documented in schema.mdx now before we forget about them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just removed support for them for now so we can make sure they're in the place we want them in a future PR.

@vercel vercel bot temporarily deployed to Preview June 8, 2021 05:46 Inactive
@vercel vercel bot temporarily deployed to Preview June 8, 2021 05:48 Inactive
@emmatown emmatown requested a review from timleslie June 8, 2021 05:48
@vercel vercel bot temporarily deployed to Preview June 8, 2021 05:52 Inactive
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good to go! We've got a week until we ship, so we can clean up anything we find during the week. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants