Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for the filters #5633

Merged
merged 7 commits into from
May 7, 2021
Merged

Some fixes for the filters #5633

merged 7 commits into from
May 7, 2021

Conversation

gwyneplaine
Copy link
Contributor

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2021

🦋 Changeset detected

Latest commit: 817b8d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/4Fu9VgqiN1X4uBcYKXKwJ8WCezLe
✅ Preview: https://keystone-next-docs-git-fix-filters-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview May 6, 2021 06:19 Inactive
@vercel vercel bot temporarily deployed to Preview May 6, 2021 06:21 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 6, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 817b8d7:

Sandbox Source
@keystone-next/example-sandbox Configuration

@gautamsi
Copy link
Member

gautamsi commented May 6, 2021

We were missing a filter is_null: true for all nullable field.

Can you add it if not already.
@timleslie @JedWatson

@JedWatson
Copy link
Member

@gautamsi that's on our list, we're in the middle of a big change to fields that I've just written up here: #5635

As part of that, we're going to be updating filters across all our field types

@gautamsi
Copy link
Member

gautamsi commented May 6, 2021

I see big changes, thanks for the heads up

@gwyneplaine gwyneplaine requested a review from a team May 7, 2021 01:47
@vercel vercel bot temporarily deployed to Preview May 7, 2021 01:47 Inactive
Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changeset

@vercel vercel bot temporarily deployed to Preview May 7, 2021 01:52 Inactive
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good 👍

@vercel vercel bot temporarily deployed to Preview May 7, 2021 02:03 Inactive
@gwyneplaine gwyneplaine requested a review from emmatown May 7, 2021 02:05
@gwyneplaine gwyneplaine enabled auto-merge (squash) May 7, 2021 02:05
@vercel vercel bot temporarily deployed to Preview May 7, 2021 02:06 Inactive
@gwyneplaine gwyneplaine merged commit 2b3efc8 into master May 7, 2021
@gwyneplaine gwyneplaine deleted the fix/filters branch May 7, 2021 02:12
@gwyneplaine gwyneplaine restored the fix/filters branch May 7, 2021 05:16
@JedWatson JedWatson deleted the fix/filters branch May 10, 2021 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants