Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5604/fix query caching #5631

Merged
merged 7 commits into from
May 7, 2021
Merged

5604/fix query caching #5631

merged 7 commits into from
May 7, 2021

Conversation

gwyneplaine
Copy link
Contributor

@gwyneplaine gwyneplaine commented May 6, 2021

Fixes #5604:

  • pageSize query no longer cached
  • page query no longer cached
  • sortBy query now cached
  • field filters remain cached
  • column queries remain cached
  • caching effect now checks for whether the router is ready or not.
  • Added a 'reset to defaults' button**

This needs better design and thought, but gets the job done for now.

query-caching-fixed.mov

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2021

🦋 Changeset detected

Latest commit: edeaa3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/A6W94nqwFqmbmgWeWhHMqHodMfNY
✅ Preview: https://keystone-next-docs-git-5604-fix-query-caching-keystonejs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 6, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit edeaa3d:

Sandbox Source
@keystone-next/example-sandbox Configuration

@gwyneplaine gwyneplaine requested a review from a team May 6, 2021 05:17
@vercel vercel bot temporarily deployed to Preview May 6, 2021 05:18 Inactive
@vercel vercel bot temporarily deployed to Preview May 6, 2021 05:20 Inactive
@vercel vercel bot temporarily deployed to Preview May 6, 2021 05:29 Inactive
@gwyneplaine gwyneplaine requested a review from emmatown May 6, 2021 05:30
@vercel vercel bot temporarily deployed to Preview May 7, 2021 00:47 Inactive
@gwyneplaine gwyneplaine enabled auto-merge (squash) May 7, 2021 00:47
@gwyneplaine gwyneplaine merged commit 53225b0 into master May 7, 2021
@gwyneplaine gwyneplaine deleted the 5604/fix-query-caching branch May 7, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local-storage query caching in admin-ui not working as intended
2 participants