Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sorting on many relationships #5622

Merged
merged 2 commits into from
May 6, 2021

Conversation

timleslie
Copy link
Contributor

Sorting a list by a many relationship doesn't have a meaningful interpretation. In practice, attempting to do this would return errors. This change prevents the Admin UI from throwing errors from the list view when a user attempts to sort by a man relationship.

@vercel
Copy link

vercel bot commented May 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/BeU2Kecawnrt8autu3oyFjPMbgiv
✅ Preview: https://keystone-next-git-remove-orderable-from-relationships-k-ac2a95.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2021

🦋 Changeset detected

Latest commit: 95baee0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@keystone-next/app-basic Patch
@keystone-next/example-todo Patch
@keystone-next/fields Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 95baee0:

Sandbox Source
@keystone-next/example-sandbox Configuration

@timleslie timleslie requested a review from a team May 5, 2021 23:12
Copy link
Contributor

@gwyneplaine gwyneplaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vercel vercel bot temporarily deployed to Preview May 6, 2021 00:15 Inactive
@timleslie timleslie enabled auto-merge (squash) May 6, 2021 00:17
@timleslie timleslie merged commit bb89208 into master May 6, 2021
@timleslie timleslie deleted the remove-orderable-from-relationships branch May 6, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants