Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed tutorial markup to be more inline with the rest of the system #5469

Merged
merged 1 commit into from
Apr 15, 2021
Merged

fixed tutorial markup to be more inline with the rest of the system #5469

merged 1 commit into from
Apr 15, 2021

Conversation

dominikwilkowski
Copy link
Contributor

@dominikwilkowski dominikwilkowski commented Apr 15, 2021 •
edited
Loading

  • Removed the Alert component as it was already implemented via a hacky mdx thing ?> and !>
  • Removed the Alert component from all mdx files and used new md syntax
  • Moved assetes of tutorial into public folder

@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2021

⚠️ No Changeset found

Latest commit: b8209a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/A3xqZs835aLHR2RuqLPT8u4GKX9i
✅ Preview: https://keystone-next-docs-git-dom-tut-markup-keystonejs.vercel.app

@dominikwilkowski dominikwilkowski requested review from a team and removed request for bladey April 15, 2021 03:06
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b8209a9:

Sandbox Source
@keystone-next/example-sandbox Configuration

@dominikwilkowski dominikwilkowski merged commit 5b349cc into dom/tut-fix Apr 15, 2021
@dominikwilkowski dominikwilkowski deleted the dom/tut-markup branch April 15, 2021 03:42
dominikwilkowski added a commit that referenced this pull request Apr 15, 2021
@dominikwilkowski
fixed svg fonts and position (#5468)
d8c04b5 
* fixed svg fonts and position

* “prettier”

* fixed tutorial markup to be more inline with the rest of the system (#5469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JedWatson JedWatson JedWatson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikwilkowski @JedWatson