Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cloudinary tests #5386

Merged
merged 4 commits into from
Apr 7, 2021
Merged

Enable cloudinary tests #5386

merged 4 commits into from
Apr 7, 2021

Conversation

timleslie
Copy link
Contributor

@timleslie timleslie commented Apr 6, 2021

Re-enabling the cloudinary tests while we're doing some work on moving the cloudinary code around.

Update: I've made the changes required to make the tests all pass, but I'm going to leave them disabled, because we will completely chew through our API limits if they're enabled on all branches. We can now enable them on branches as needed when making changes around the cloudinary field type.

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2021

🦋 Changeset detected

Latest commit: 9265dac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/fields-cloudinary-image-legacy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/HWqqfiq8Hutgt24szDaAJyWhfDUA
✅ Preview: https://keystone-next-docs-git-cloudinary-tests-keystonejs.vercel.app

@timleslie timleslie changed the title Enable cloudinary tests [WIP] Enable cloudinary tests Apr 6, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 6, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9265dac:

Sandbox Source
@keystone-next/example-sandbox Configuration

@vercel vercel bot temporarily deployed to Preview April 6, 2021 22:23 Inactive
@vercel vercel bot temporarily deployed to Preview April 6, 2021 22:27 Inactive
@vercel vercel bot temporarily deployed to Preview April 7, 2021 00:00 Inactive
@timleslie timleslie force-pushed the cloudinary-tests branch 2 times, most recently from e2f05ae to 3ac5c36 Compare April 7, 2021 01:28
@vercel vercel bot temporarily deployed to Preview April 7, 2021 01:30 Inactive
@vercel vercel bot temporarily deployed to Preview April 7, 2021 01:46 Inactive
@vercel vercel bot temporarily deployed to Preview April 7, 2021 01:51 Inactive
@timleslie timleslie changed the title [WIP] Enable cloudinary tests Enable cloudinary tests Apr 7, 2021
@timleslie timleslie requested a review from a team April 7, 2021 01:52
@vercel vercel bot temporarily deployed to Preview April 7, 2021 01:54 Inactive
@vercel vercel bot temporarily deployed to Preview April 7, 2021 01:57 Inactive
@timleslie timleslie enabled auto-merge (squash) April 7, 2021 01:57
@vercel vercel bot temporarily deployed to Preview April 7, 2021 02:09 Inactive
@timleslie timleslie merged commit 952db71 into master Apr 7, 2021
@timleslie timleslie deleted the cloudinary-tests branch April 7, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants