Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert prisma adapter to typescript #5284

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Conversation

timleslie
Copy link
Contributor

@timleslie timleslie commented Mar 30, 2021

This is a first pass at converting this module to TypeScript. We will need to loop back and clean up a lot of the types once other areas of the system have been correctly typed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2021

🦋 Changeset detected

Latest commit: 8a144ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@keystone-next/adapter-prisma-legacy Minor
@keystone-next/keystone Patch
@keystone-next/test-utils-legacy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/9f8RiqiNq8Yj8i2F4tspm5yZckS1
✅ Preview: https://keystone-next-docs-git-typescript-prisma-adapter-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview March 30, 2021 23:03 Inactive
@vercel vercel bot temporarily deployed to Preview March 31, 2021 03:24 Inactive
@vercel vercel bot temporarily deployed to Preview March 31, 2021 03:30 Inactive
@vercel vercel bot temporarily deployed to Preview March 31, 2021 04:55 Inactive
@vercel vercel bot temporarily deployed to Preview March 31, 2021 04:59 Inactive
@vercel vercel bot temporarily deployed to Preview April 6, 2021 01:54 Inactive
@vercel vercel bot temporarily deployed to Preview April 7, 2021 07:41 Inactive
@vercel vercel bot temporarily deployed to Preview April 7, 2021 07:46 Inactive
@vercel vercel bot temporarily deployed to Preview April 7, 2021 23:24 Inactive
@vercel vercel bot temporarily deployed to Preview April 7, 2021 23:26 Inactive
@vercel vercel bot temporarily deployed to Preview April 7, 2021 23:48 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8a144ba:

Sandbox Source
@keystone-next/example-sandbox Configuration

@vercel vercel bot temporarily deployed to Preview April 8, 2021 00:54 Inactive
@vercel vercel bot temporarily deployed to Preview April 8, 2021 01:43 Inactive
@vercel vercel bot temporarily deployed to Preview April 8, 2021 01:57 Inactive
@timleslie timleslie changed the title [WIP] Convert prisma adapter to typescript Convert prisma adapter to typescript Apr 8, 2021
@vercel vercel bot temporarily deployed to Preview April 8, 2021 02:01 Inactive
@timleslie timleslie requested a review from a team April 8, 2021 02:04
};
listAdapters: Record<string, PrismaListAdapter>;
listAdapterClass?: any;
_prismaClient?: any;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, legacy from when branch was first made. Will remove 👍

@vercel vercel bot temporarily deployed to Preview April 8, 2021 02:14 Inactive
@timleslie timleslie enabled auto-merge (squash) April 8, 2021 02:16
@vercel vercel bot temporarily deployed to Preview April 8, 2021 02:18 Inactive
@timleslie timleslie merged commit 8ab2c9b into master Apr 8, 2021
@timleslie timleslie deleted the typescript-prisma-adapter branch April 8, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants