Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert cache-hints test to typescript #5207

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Convert cache-hints test to typescript #5207

merged 2 commits into from
Mar 24, 2021

Conversation

timleslie
Copy link
Contributor

This test converts the cache-hints test to typescript and then marks them as skippable, as we need to make some API changes before these tests will pass. See #5143

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2021

⚠️ No Changeset found

Latest commit: 5de2aab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/8rH55RYGDvnapvybWEB6bjDEvEpT
✅ Preview: https://keystone-next-docs-git-cache-hint-tests-2-keystonejs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 23, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5de2aab:

Sandbox Source
@keystone-next/example-sandbox Configuration

@timleslie timleslie requested a review from a team March 23, 2021 22:19
@vercel vercel bot temporarily deployed to Preview March 23, 2021 23:13 Inactive
@vercel vercel bot temporarily deployed to Preview March 23, 2021 23:45 Inactive
@timleslie timleslie enabled auto-merge (squash) March 23, 2021 23:48
@vercel vercel bot temporarily deployed to Preview March 24, 2021 00:27 Inactive
@timleslie timleslie merged commit fa9ccc0 into master Mar 24, 2021
@timleslie timleslie deleted the cache-hint-tests-2 branch March 24, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants