Skip to content

Commit

Permalink
Fix incorrect types which said that field level delete access control…
Browse files Browse the repository at this point in the history
… exists when it does not (#5509)
  • Loading branch information
emmatown committed Apr 21, 2021
1 parent 9096966 commit 7e81b52
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/eleven-mayflies-design.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@keystone-next/types': patch
---

Fixed incorrect types which said that field level delete access control exists when it does not
4 changes: 0 additions & 4 deletions packages-next/types/src/config/access-control.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,18 +109,14 @@ type FieldUpdateAccessArgs<
item: GeneratedListTypes['backing'];
};

type FieldDeleteAccessArgs = DeleteAccessArgs & BaseFieldAccessArgs;

export type FieldAccessControl<GeneratedListTypes extends BaseGeneratedListTypes> =
| {
create?: IndividualFieldAccessControl<FieldCreateAccessArgs<GeneratedListTypes>>;
read?: IndividualFieldAccessControl<FieldReadAccessArgs<GeneratedListTypes>>;
update?: IndividualFieldAccessControl<FieldUpdateAccessArgs<GeneratedListTypes>>;
delete?: IndividualFieldAccessControl<FieldDeleteAccessArgs>;
}
| IndividualFieldAccessControl<
| FieldCreateAccessArgs<GeneratedListTypes>
| FieldReadAccessArgs<GeneratedListTypes>
| FieldUpdateAccessArgs<GeneratedListTypes>
| FieldDeleteAccessArgs
>;

1 comment on commit 7e81b52

@vercel
Copy link

@vercel vercel bot commented on 7e81b52 Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.