Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(web): engine/configuration -> engine/paths 🧩 #8459

Conversation

jahorton
Copy link
Contributor

@jahorton jahorton commented Mar 17, 2023

A followup to #8458 (comment) - performs the child-project rename in the title, since the child-project now only contains functionality related to pathing configurations for KMW.

@keymanapp-test-bot skip

@jahorton jahorton added this to the A17S8 milestone Mar 17, 2023
@jahorton jahorton requested a review from mcdurdin as a code owner March 17, 2023 04:43
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Mar 17, 2023

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from change/web/engine-configuration to feature-esmodule-web-engine March 27, 2023 01:14
@jahorton jahorton merged commit 58ba743 into feature-esmodule-web-engine Mar 27, 2023
@jahorton jahorton deleted the change/web/child-rename-configuration-to-paths branch March 27, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants