Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): tidy up LDML keyboard project template 🌱 #10474

Conversation

mcdurdin
Copy link
Member

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jan 23, 2024

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(developer): tidy up LDML keyboard project template fix(developer): tidy up LDML keyboard project template 🌱 Jan 23, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S31 milestone Jan 23, 2024
@mcdurdin mcdurdin linked an issue Jan 23, 2024 that may be closed by this pull request
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there a reason the template isn't sourced from an actual xml file? might be easier to maintain.

@mcdurdin
Copy link
Member Author

Is there a reason the template isn't sourced from an actual xml file? might be easier to maintain.

Laziness. Means adding an extra file to the install template and path maintenance etc. Agree though, it would be better long-term. Also noting that the template generation as written in Delphi in this code is deprecated before it even lands because we will replace it with kmc generate soon:

declareGenerate(program);

Base automatically changed from fix/developer/10469-use-keyboard3-tag to epic/core/9999-normalization January 26, 2024 04:31
@mcdurdin mcdurdin merged commit 5c63ec5 into epic/core/9999-normalization Jan 26, 2024
5 checks passed
@mcdurdin mcdurdin deleted the fix/developer/10470-ldml-keyboard-template branch January 26, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(developer): use this as the basic ldml keyboard template
2 participants