refactor(core): split context API from Core primary API 🌱 #10401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
bot
changed the title
ermshiperete
approved these changes
Jan 16, 2024
mcdurdin
force-pushed
the
refactor/mac/9999-remove-legacy-context-api-calls
branch
from
7b44175
to
823b772
Compare
Relates to #9999. Fixes #10384. The context API endpoints should no longer be considered as part of the standard Core API. The only consumers that have a need to access these APIs are the IMX integration in Engine for Windows, and the Keyman Developer Debugger. These symbols are currently used by Developer: * `km_core_context` struct * `km_core_context_type` enum * `km_core_context_item` struct * `KM_CORE_CONTEXT_ITEM_END` macro * `km_core_state_context()` * `km_core_context_set()` * `km_core_context_clear()` These symbols are currently used by Windows IMX: * `km_core_context` struct * `km_core_context_type` enum * `km_core_context_item` struct * `KM_CORE_CONTEXT_ITEM_END` macro * `km_core_context_items_dispose()` * `km_core_context_item_list_size()` * `km_core_state_get_intermediate_context()` The following functions and symbols are moving to keyman_core_api_context.h: * `km_core_context` struct * `km_core_context_type` enum * `km_core_context_item` struct * `KM_CORE_CONTEXT_ITEM_END` macro * `km_core_state_context()` function * `km_core_state_get_intermediate_context()` function * `km_core_context_set()` function * `km_core_context_clear()` function * `km_core_context_get()` function * `km_core_context_items_from_utf16()` function * `km_core_context_items_from_utf8()` function * `km_core_context_items_to_utf8()` function * `km_core_context_items_to_utf16()` function * `km_core_context_items_to_utf32()` function * `km_core_context_items_dispose()` function * `km_core_context_length()` function * `km_core_context_append()` function * `km_core_context_shrink()` function * `km_core_context_item_list_size()` function
mcdurdin
force-pushed
the
refactor/core/9999-split-context-apis
branch
from
e5c2525
to
671973b
Compare
Base automatically changed from
refactor/mac/9999-remove-legacy-context-api-calls
to
epic/core/9999-normalization
January 18, 2024 03:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #9999.
Fixes #10384.
The context API endpoints should no longer be considered as part of the standard Core API. The only consumers that have a need to access these APIs are the IMX integration in Engine for Windows, and the Keyman Developer Debugger.
These symbols are currently used by Developer:
km_core_contextstructkm_core_context_typeenumkm_core_context_itemstructKM_CORE_CONTEXT_ITEM_ENDmacrokm_core_state_context()km_core_context_set()km_core_context_clear()These symbols are currently used by Windows IMX:
km_core_contextstructkm_core_context_typeenumkm_core_context_itemstructKM_CORE_CONTEXT_ITEM_ENDmacrokm_core_context_items_dispose()km_core_context_item_list_size()km_core_state_get_intermediate_context()The following functions and symbols are moving to keyman_core_api_context.h:
km_core_contextstructkm_core_context_typeenumkm_core_context_itemstructKM_CORE_CONTEXT_ITEM_ENDmacrokm_core_state_context()functionkm_core_state_get_intermediate_context()functionkm_core_context_set()functionkm_core_context_clear()functionkm_core_context_get()functionkm_core_context_items_from_utf16()functionkm_core_context_items_from_utf8()functionkm_core_context_items_to_utf8()functionkm_core_context_items_to_utf16()functionkm_core_context_items_to_utf32()functionkm_core_context_items_dispose()functionkm_core_context_length()functionkm_core_context_append()functionkm_core_context_shrink()functionkm_core_context_item_list_size()function@keymanapp-test-bot skip