feat(core): normalize input context 🌱 #10382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the application context member of state and a corresponding, failing unit test, which starts the process of verifying the handling of the application context.
First half of #9999. Adds support for normalization (to NFD) of input app context into the cached context. The keyboard processor will work with the NFD cached context. Adds unit tests for the normalization as part of the LDML keyboard processor test suite. TODO: * Comparing modified cached context to app context to determine the transform required to send to the app * Handling illegal unicode and unpaired surrogates on input context
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
commented
Jan 15, 2024
| @@ -0,0 +1,222 @@ | |||
| /* | |||
There was a problem hiding this comment.
Note, refactored km_core_state_context_set_if_needed() and related helper functions out of km_core_state_api.cpp. It's been extensively rewritten so should be reviewed in its entirety anyway.
…ore/9999-normalization-of-context Note: shifted minor changes from action_api.cpp to new state_context_api.cpp.
mcdurdin
changed the title
Base automatically changed from
feat/core/10365-context-debug
to
epic/core/9999-normalization
January 16, 2024 02:38
mcdurdin
merged commit a97237b
into
epic/core/9999-normalization
15 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First half of #9999.
Adds the application context member of state object, which starts the process of verifying the handling of the application context.
Adds support for normalization (to NFD) of input app context into the cached context. The keyboard processor will work with the NFD cached context.
Adds unit tests for the normalization as part of the LDML keyboard processor test suite.
For follow-up PRs:
@keymanapp-test-bot skip