Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(developer): debugger: manage app_context as well as cached_context 🌱 #10214

Closed
Tracked by #9999
mcdurdin opened this issue Dec 11, 2023 · 1 comment · Fixed by #10462
Closed
Tracked by #9999

refactor(developer): debugger: manage app_context as well as cached_context 🌱 #10214

mcdurdin opened this issue Dec 11, 2023 · 1 comment · Fixed by #10462
Assignees
@mcdurdin
Labels
developer/ refactor
Milestone
A17S31

Comments

@mcdurdin
Copy link
Member

No description provided.

@mcdurdin mcdurdin mentioned this issue Dec 11, 2023
Closed
7 tasks
@mcdurdin mcdurdin changed the title Developer debugger: use km_core_state_context_set_if_needed refactor(developer): debugger: use km_core_state_context_set_if_needed Dec 11, 2023
@mcdurdin mcdurdin self-assigned this Dec 11, 2023
@mcdurdin mcdurdin added this to the A17S30 milestone Dec 11, 2023
@mcdurdin mcdurdin changed the title refactor(developer): debugger: use km_core_state_context_set_if_needed refactor(developer): debugger: use km_core_state_context_set_if_needed 🌱 Jan 15, 2024
@mcdurdin mcdurdin mentioned this issue Jan 18, 2024
Closed
@mcdurdin mcdurdin modified the milestones: A17S30, A17S31 Jan 20, 2024
@mcdurdin
Copy link
Member Author

The debugger needs to continue to use km_core_context_set because it tracks the markers itself internally for visual representation. Thus, changing this to refer to keeping app_context up to date as well as cached context.

@mcdurdin mcdurdin changed the title refactor(developer): debugger: use km_core_state_context_set_if_needed 🌱 refactor(developer): debugger: manage app_context as well as cached_context 🌱 Jan 22, 2024
mcdurdin added a commit that referenced this issue Jan 22, 2024
@mcdurdin
refactor(developer): update app context as well as cached context for…
fe88d04 
… LDML keyboard debugger

Relates to #10214.
mcdurdin added a commit that referenced this issue Jan 22, 2024
@mcdurdin
refactor(developer): update app context as well as cached context for…
aee59db 
… KMN keyboard debugger

Fixes #10214.
@mcdurdin mcdurdin mentioned this issue Jan 22, 2024
Merged
@mcdurdin mcdurdin linked a pull request Jan 22, 2024 that will close this issue
refactor(developer): update app context as well as cached context for keyboard debuggers 🌱 #10462
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
developer/ refactor
Projects
None yet
Milestone
A17S31
1 participant
@mcdurdin