docs: Update API's for adjusting Android longpress delay #1500
Conversation
|
|
||
| The following code illustrates the use of `setLongpressDelay()`: | ||
| ```java | ||
| int currentDelayTimeMS = 250; |
There was a problem hiding this comment.
The Keyman for Android menu has a range of 300ms to 1500 ms. But the API doesn't have any gating on what keyboard developers may use.
There was a problem hiding this comment.
I was hoping this information would be added to the docs. Also, we should really be putting limits into public API functions.
There was a problem hiding this comment.
Yeah, we can document a range and add gating to KMManager.
300-1500 ms? Or will somebody eventually want a 2000ms delay?
There was a problem hiding this comment.
I think we should match what Keyman app supports
| Use this method to update options in the KeymanWeb keyboard. | ||
| * Number of milliseconds to trigger a longpress gesture | ||
|
|
||
| This method requires a keyboard to be loaded for the values to take effect. |
There was a problem hiding this comment.
Why would this be needed? Why can't KMManager handle this itself internally?
There was a problem hiding this comment.
There may be other keyboard preferences that change/get stored.
This API propagates the value to KeymanWeb to use.
There was a problem hiding this comment.
KMManager already knows the value though -- so why can't it be responsible for telling KMW? It seems like exposing internals to have this API at all (and I know I approved the previous PR, just thinking about this a bit more now, sorry!). I think we should review that because it's definitely less than ideal to push this responsibility of managing internal preference updates onto the app.
There was a problem hiding this comment.
I was waiting on merging this PR to see if we needed a Monday design discussion about the interactions between: Keyman Engine API + KeymanWeb + UI
There was a problem hiding this comment.
Can you write up a spec document on the various bits and pieces -- where we are at today?
There was a problem hiding this comment.
k, I'll send you a Slack when I've jotted something into the Drive for you to squiz
Documents Keyman Engine for Android 18.0 API changes for keymanapp/keyman#12170 and keymanapp/keyman#12185