Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent use of spaces and tabs #33

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

YarmoM
Copy link
Contributor

@YarmoM YarmoM commented Apr 23, 2021

Summary
This PR fixes the inconsistent use of spaces and tabs in the main CSS file.

Description
It appears some lines use 2 spaces, some use a tab and others still use both 2 spaces followed by a tab. While this does not impact the minified version, the non-minified version will IMHO improve by using a consistent indentation.

Given that the majority of lines use an indentation of 2 spaces, I chose this as the convention. I'll leave it at @kevquirk 's discretion to overrule the chosen convention and, upon doing so, I'll update the PR.

Additional measures
To prevent future PRs from messing up the indentation, one could add automation rules with packages like prettier to either check indentation at committing and refuse if the changes do not adhere to the convention, or apply the convention at committing or later.

Most likely, these proposed measures are overkill, and could be substituted by carefully inspection of PRs.

@kevquirk
Copy link
Owner

Thanks for this Yarmo. Someone raised this a while ago, but I haven't had time to look into it, so this really helps. It seems that my text editor (Atom) hides these discrepancies for some reason, so I had no idea they were there.

@kevquirk kevquirk merged commit fcbbad7 into kevquirk:main Apr 23, 2021
@YarmoM YarmoM deleted the fix_spacing branch April 24, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants