Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of -apple-system #13

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Fix name of -apple-system #13

merged 1 commit into from
Jan 8, 2021

Conversation

bobdenotter
Copy link
Contributor

The name of the system font on MacOs is actually -apple-system. See also: https://css-tricks.com/snippets/css/system-font-stack/

@badcat
Copy link

badcat commented Jan 8, 2021

If we're on the subject of fonts, then perhaps avenir next, segoe ui and helvetica neue should be in quotes?
--sans-font: -apple-system, BlinkMacSystemFont, "avenir next", avenir, "Nimbus Sans L", roboto, noto, "segoe ui", arial, helvetica, "helvetica neue", sans-serif;

@bobdenotter
Copy link
Contributor Author

@badcat Yes.. Didn't want to change too much, but I think that'd be better.. And, while we're at it: Proper capitalisation as well. I'll update the PR.

Copy link
Owner

@kevquirk kevquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - not sure how I missed that!

@kevquirk kevquirk merged commit d5699d4 into kevquirk:main Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants