Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate types from graphql queries #822

Merged
merged 1 commit into from
Jul 30, 2018
Merged

generate types from graphql queries #822

merged 1 commit into from
Jul 30, 2018

Conversation

kevinhughes27
Copy link
Owner

@kevinhughes27 kevinhughes27 commented Jul 29, 2018

Changes:

  • use a fork of relay (soon to be merged Language plugin support. facebook/relay#2293) to generate typescript files from relay instead of javascript
  • I added my own script to copy these types to the global types folder so that I don't have to include them everywhere. Its a bit less explicit but the relay type names are super obvious so I am okay with it.
  • I updated a lot of always present fields to be null: false in the API spec. This creates some issues with interop with the old admin that I found a new work around for.
  • I also changed the API to use plain ID fields in a few places. For CRUD actions its nicer on the client to use the plain ID
  • I changed the API to only return fields with maps and made the types non null

@kevinhughes27 kevinhughes27 force-pushed the graphql-types branch 12 times, most recently from 479e515 to 98a6caa Compare July 30, 2018 19:22
@kevinhughes27 kevinhughes27 merged commit 6a93e8c into master Jul 30, 2018
@kevinhughes27 kevinhughes27 deleted the graphql-types branch July 30, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant