Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add make target and actions job to execute tests #85

Merged
merged 2 commits into from
Jan 3, 2024
Merged

[CI] Add make target and actions job to execute tests #85

merged 2 commits into from
Jan 3, 2024

Conversation

kaiiorg
Copy link
Contributor

@kaiiorg kaiiorg commented Jan 2, 2024 •
edited
Loading

Relates to #84

  • Adds make target to execute tests; make test
  • Modified readme to mention the new make target
  • Added github actions job to execute tests and upload a coverage report

@kevinanielsen kevinanielsen added docs Improvements or additions to documentation api Improvements or additions to the api go Language: Go labels Jan 2, 2024
@kaiiorg
Copy link
Contributor Author

kaiiorg commented Jan 2, 2024

Not sure why that's failing; I'll work on fixing it. Might take me a few attempts

@kevinanielsen
Copy link
Owner

It's failing becuase the frontend has not been build - The pnpm build script needs to be run for the go files to compile.
It looks great so far otherwise!

@kevinanielsen kevinanielsen linked an issue Jan 2, 2024 that may be closed by this pull request
[CI] Execute tests with github actions and add make target for local execution #84
Closed
@kevinanielsen kevinanielsen added ci Improvements or additions to continuous integration and removed docs Improvements or additions to documentation api Improvements or additions to the api labels Jan 2, 2024
@kaiiorg
Copy link
Contributor Author

kaiiorg commented Jan 2, 2024

Ah, that explains that. I'll get that fixed. Thanks!

@kevinanielsen kevinanielsen added docs Improvements or additions to documentation api Improvements or additions to the api labels Jan 2, 2024
@kaiiorg
Copy link
Contributor Author

kaiiorg commented Jan 2, 2024

Ok, I think we're good to go now. The job uploads the coverage report HTML file, though I'm sure there are better ways of doing it. Baby steps : P

@kevinanielsen
Copy link
Owner

This looks great! Merging now! - Will the HTML file be served somewhere so it can be found?

kevinanielsen
kevinanielsen approved these changes Jan 3, 2024
View reviewed changes
Copy link
Owner

@kevinanielsen kevinanielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinanielsen kevinanielsen merged commit 13c4b35 into kevinanielsen:main Jan 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinanielsen kevinanielsen kevinanielsen approved these changes

Assignees
No one assigned
Labels
api Improvements or additions to the api ci Improvements or additions to continuous integration docs Improvements or additions to documentation go Language: Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Execute tests with github actions and add make target for local execution
2 participants
@kaiiorg @kevinanielsen