-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add API endpoint for renaming files #27
feat: Add API endpoint for renaming files #27
Conversation
Signed-off-by: Erik Westra <e.s.westra.95@gmail.com>
|
I have done some restructure change of database package. Other than that everything is good. |
Hey I think you are doing rename only in database. We need to do it in filesystem also? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Everything looks good! If you decide to contribute again it would be very welcome! |
Since the database finds the files via checksum and not filename, it should be fine to only rename using database. |
@kevinanielsen As ankit pointed out renaming the actual file in the fs was missing, I have just pushed that up now would you like me to reopen the pull request |
@webstradev Yes please, that would be great. @ankit-pn you were right, it was missing :) |
Done |
Renames are done with simple update statesments using GORM.
I follow the same router grouping pattern as you have done previously for upload and suggest we do the same for delete @ankit-pn . Unless you would like to suggest a different structure, I'm happy to adjust.
Closes #18