Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add API endpoint for renaming files #27

Merged
merged 1 commit into from
Dec 19, 2023
Merged

feat: Add API endpoint for renaming files #27

merged 1 commit into from
Dec 19, 2023

Conversation

webstradev
Copy link
Contributor

Renames are done with simple update statesments using GORM.

I follow the same router grouping pattern as you have done previously for upload and suggest we do the same for delete @ankit-pn . Unless you would like to suggest a different structure, I'm happy to adjust.

Closes #18

Signed-off-by: Erik Westra <e.s.westra.95@gmail.com>
Copy link

changeset-bot bot commented Dec 18, 2023

⚠️ No Changeset found

Latest commit: da7dc9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ankit-pn
Copy link
Contributor

I have done some restructure change of database package. Other than that everything is good.

@ankit-pn
Copy link
Contributor

Hey I think you are doing rename only in database. We need to do it in filesystem also?

Copy link
Owner

@kevinanielsen kevinanielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kevinanielsen
Copy link
Owner

Everything looks good! If you decide to contribute again it would be very welcome!

@kevinanielsen kevinanielsen merged commit 3a1853a into kevinanielsen:main Dec 19, 2023
@kevinanielsen
Copy link
Owner

Hey I think you are doing rename only in database. We need to do it in filesystem also?

Since the database finds the files via checksum and not filename, it should be fine to only rename using database.

@webstradev
Copy link
Contributor Author

@kevinanielsen As ankit pointed out renaming the actual file in the fs was missing, I have just pushed that up now would you like me to reopen the pull request

@kevinanielsen
Copy link
Owner

@webstradev Yes please, that would be great. @ankit-pn you were right, it was missing :)

@webstradev
Copy link
Contributor Author

@webstradev Yes please, that would be great. @ankit-pn you were right, it was missing :)

Done
#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add API endpoint for renaming files
3 participants