Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Quickstart app with docker #135

Closed
wants to merge 5 commits into from

Conversation

amritupreti
Copy link
Contributor

This PR adds a Dockerfile and docker-compose.yml to containerize the application. The Dockerfile sets up multi-stage builds for the front-end and back-end, while docker-compose.yml orchestrates container deployment with persistent storage for uploaded files and database data.

Key Changes:
Dockerfile: Multi-stage build for Node.js and Go applications.
docker-compose.yml: Manages service orchestration and persistence.

Instructions:
Build the Docker image:
docker build -t my-app .

Start the application:
docker-compose up -d

Please review and provide feedback.

@yunimoo
Copy link
Contributor

yunimoo commented Jul 23, 2024

I seem to be running into an error while testing these changes.

 > [server gowork 7/7] RUN go build -o /app/main .:
0.452 ui/embed.go:14:12: pattern build: no matching files found
------
failed to solve: process "/bin/sh -c go build -o /app/main ." did not complete successfully: exit code: 1

I believe that instead of going for this, we can potentially try to release an official docker image - rather than the user building it themselves. We can leave the docker-compose as an example for the user to use while deploying on their own environment.

@kevinanielsen, is this something that you would like to have? I could work on a pipeline to get official images for this project.

@kevinanielsen kevinanielsen added the docs Improvements or additions to documentation label Jul 23, 2024
@amritupreti
Copy link
Contributor Author

I seem to be running into an error while testing these changes.

 > [server gowork 7/7] RUN go build -o /app/main .:
0.452 ui/embed.go:14:12: pattern build: no matching files found
------
failed to solve: process "/bin/sh -c go build -o /app/main ." did not complete successfully: exit code: 1

I believe that instead of going for this, we can potentially try to release an official docker image - rather than the user building it themselves. We can leave the docker-compose as an example for the user to use while deploying on their own environment.

@kevinanielsen, is this something that you would like to have? I could work on a pipeline to get official images for this project.

I have just fixed it. You can try now. I forgot to copy the ui build into the build process of go.

@yunimoo
Copy link
Contributor

yunimoo commented Jul 23, 2024

I seem to be running into an error while testing these changes.

 > [server gowork 7/7] RUN go build -o /app/main .:
0.452 ui/embed.go:14:12: pattern build: no matching files found
------
failed to solve: process "/bin/sh -c go build -o /app/main ." did not complete successfully: exit code: 1

I believe that instead of going for this, we can potentially try to release an official docker image - rather than the user building it themselves. We can leave the docker-compose as an example for the user to use while deploying on their own environment.
@kevinanielsen, is this something that you would like to have? I could work on a pipeline to get official images for this project.

I have just fixed it. You can try now. I forgot to copy the ui build into the build process of go.

Thanks, looks good for me

@amritupreti
Copy link
Contributor Author

amritupreti commented Jul 23, 2024 via email

@amritupreti
Copy link
Contributor Author

amritupreti commented Jul 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants