fix: adding file name validation before adding file to database #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinanielsen
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an error that even if
util.FilterFilenamereturn an error, the application writes it to the databaseFollow the flow to reproduce the error
upload file with name
Arquitetura Limpa - O Guia do Artesão para Estrutura e Design de Software (Robert C. Martin) (Z-Library).pdfguive an errorBut even so, it still registers in the database
If I try to delete it, an error occurs.
However, even with the error, it still gets deleted from the database (requires refreshing the page).
With the current state of this pull request, the issue is resolved. However, we need to investigate why the util.FilterFilename function returned an error for the file name. If necessary, we may have to make modifications to the util.FilterFilename function. Additionally, we need to look into why step 3 returned an error when I clicked delete. Nonetheless, in step 4, after refreshing the page, the data was deleted from the database despite the error.