Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/case: Add authentication/user test #79

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

axkar
Copy link
Collaborator

@axkar axkar commented Jul 4, 2023

Added a test case for adding/deleting a user

Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small request, in the steps after "Add new user", maybe add user/pass in the with lines, like Tobias did in the hostname test?

 with test.step(f"Verify new hostname ({new})"):

This makes it more obvious that we actually randomize the username and password.

Other than that, it looks good, nice job! Let's continue like this, one PR per test. When you run out of these obvious test cases then we can have a talk about the next round before we have a real sitdown about more comprehensive use-case tests :-)

@axkar
Copy link
Collaborator Author

axkar commented Jul 4, 2023

I see, I did have those in the step name until we decided to use 64 characters.
Would it be ugly to see random 128 characters in the test-step-name?
We have 3 options:

  • To show only username
  • To reduce number of characters
  • To let the title be long and ugly :-D

image

@troglobit
Copy link
Contributor

Hmm, good questions!

Would it be ugly to see random 128 characters in the test-step-name? We have 3 options:
* To show only username

Nah

* To reduce number of characters

How about adding random length between 8-64 chars?

* To let the title be long and ugly :-D

That's not too bad, I say we let it be long :)

@troglobit troglobit merged commit 7b99cdb into kernelkit:main Jul 4, 2023
1 check passed
@axkar axkar deleted the authentication-test branch August 18, 2023 12:58
@troglobit troglobit added this to the Infix v23.08 milestone Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants