klishd: drop privileges in client connection #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a client connects over the AF_UNIX socket we should drop privileges to match the uid and gid of that user. The '%u' translation done by the klish_prompt() function needs the USER env. variable to be set, so we do that too here. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
|
This was a good idea. Letting the forked-off child process of klishd drop its privileges so it connects as, e.g., the Later revisions of the klish project add their own UID tracking, but the daemon still runs and operates as root when connecting to sysrepo. In PR #90 I explored this further and found several possible reasons for the problems I saw. These are documented in the patch on our kkit branch of klish, which we switch to in PR #90. Since that supersedes this PR, I suggest we close this one instead. |
troglobit
added
question
|
Continuing this discussion in #90. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client connects over the AF_UNIX socket we should drop privileges to match the uid and gid of that user. The '%u' translation done by the klish_prompt() function needs the USER env. variable to be set, so we do that too here.