Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes #679

Merged
merged 12 commits into from
Oct 3, 2024
Merged

Misc fixes #679

merged 12 commits into from
Oct 3, 2024

Conversation

mattiaswal
Copy link
Contributor

@mattiaswal mattiaswal commented Oct 1, 2024 •
edited by troglobit
Loading

Description

  • Update texts for some tests for test specification
  • Fail build when test specification fails to build
  • Add a default NACM rule to OPT-in the view of password HASH , fix NETCONF ACL to limit access to password hash #499
  • Fix test error if loopback was in multiple area, fix OSPF syslog warning for loopback #586
  • Add lock to not allow configuration of loopback in multiple areas (was an exception)
  • Fix BFD in OSPF, was not possible to enable on just one interface, no one or all interfaces was the way to go.
  • Refactor YANG modules, the infix modules are now located in src/confd/yang/infix/ and are split to two,
    one simple.yang and a symlink to simple@1970-01-01.yang
  • Add new issues automatically to the project Infix&Co

Other information

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

@troglobit
Copy link
Contributor

Just a cursory glance tonight, but it looks real good! 💪 I'll give you a proper review tomorrow morning, because I have some minor comments I think you might want to address 👍

@mattiaswal mattiaswal force-pushed the fix-test-texts branch 2 times, most recently from b77414d to d636e87 Compare October 2, 2024 05:14
troglobit
troglobit requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things only.

Really appreciate the ChangeLog additions! ❤️ Although you forgot to tick it off on the checklist 😏

.github/workflows/add-issue-to-project.yml Outdated Show resolved Hide resolved
.github/workflows/add-issue-to-project.yml Show resolved Hide resolved
doc/ChangeLog.md Outdated Show resolved Hide resolved
src/confd/share/factory.d/10-nacm.json Show resolved Hide resolved
src/confd/share/factory.d/10-nacm.json Show resolved Hide resolved
src/confd/yang/confd.inc Outdated Show resolved Hide resolved
test/case/ietf_syslog/remote/test.py Outdated Show resolved Hide resolved
test/case/ietf_syslog/remote/test.py Outdated Show resolved Hide resolved
test/spec/generate_spec.py Outdated Show resolved Hide resolved
test/spec/generate_spec.py Outdated Show resolved Hide resolved
@mattiaswal
test-spec: Fail build on failed test specification build
0d98ee5 
This can fail on two ways:
* Generate topology files
  Unfortunatly the python-graphwiz has no way of detect faults
  it just show 'Warning' on stderr, catch it and if != empty, exit 1

* Generate pdf
  Here the default error level was FATAL, but for example a file
  that is included does not exist it just show an error on stdout.
  the error level is now INFO, it should always be silent.
@mattiaswal
factory-config: Add default NACM deny rule for reading password hash
2341e07 
This fix #499
@mattiaswal
test:case:usb: Update test documentation
ca122ea
@mattiaswal
confd:yang: Refactor infix YANG file names and location
6c2e554 
Instead of renaming the yang-file instead we keep the yang file
with the actual content linear, easier to review and easier to
follow changes. This only applies on all infix models,deviations
and auguments.

The actual infix-system@2038-01-19.yang is just a symlink to
ietf-system.yang which contains all the code.
@mattiaswal
test: ospf: Remove loopback from multiple areas
ff6c63a 
This is not allowed in FRR.

Fix #586
@mattiaswal
ospf: Do not enable BFD on all interfaces when enable on one interface
b88c3c3
@mattiaswal
Do not allow to configure a loopback interface in multiple areas
673ce27
@mattiaswal
Update changelog for upcoming 2024.10.0 release
363516c
@mattiaswal
Add all issues to project Infix&co when new issue is opened
9fb2b57
troglobit
troglobit approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@mattiaswal mattiaswal merged commit 3b17dd0 into main Oct 3, 2024
6 checks passed
@mattiaswal mattiaswal deleted the fix-test-texts branch October 3, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troglobit troglobit troglobit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSPF syslog warning for loopback NETCONF ACL to limit access to password hash
2 participants
@mattiaswal @troglobit