Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate and load test-config when in test-mode #569

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Generate and load test-config when in test-mode #569

merged 4 commits into from
Aug 23, 2024

Conversation

axkar
Copy link
Collaborator

@axkar axkar commented Aug 20, 2024 •
edited
Loading

Currently, it's not possible to run infix tests from an external project (based on infix) due to an incompatibility between the
configuration used in the tests (the default configuration within the image generated by the external project) and the infix
base configuration expected by the test cases.
Therefore, a simple configuration specifically for testing purposes needs to be generated within an image.
This test-config should only be generated and loaded when the device is in test mode.

mattiaswal
mattiaswal requested changes Aug 20, 2024
View reviewed changes
src/confd/bin/bootstrap Outdated Show resolved Hide resolved
src/confd/bin/bootstrap Outdated Show resolved Hide resolved
doc/introduction.md Outdated Show resolved Hide resolved
doc/introduction.md Outdated Show resolved Hide resolved
src/confd/share/test.d/10-netconf-server.json Outdated Show resolved Hide resolved
src/confd/share/test.d/10-nacm.json Outdated Show resolved Hide resolved
src/confd/share/test.d/10-infix-services.json Outdated Show resolved Hide resolved
src/confd/share/test.d/10-infix-services.json Outdated Show resolved Hide resolved
src/confd/share/test.d/10-system.json Show resolved Hide resolved
troglobit
troglobit requested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second Mattias' comments and I'd also like to understand why the config is named test-config rather than safe-config, as described in #561. Please add motivation for this discrepancy.

@mattiaswal
Copy link
Contributor

mattiaswal commented Aug 22, 2024 •
edited
Loading

I second Mattias' comments and I'd also like to understand why the config is named test-config rather than safe-config, as described in #561. Please add motivation for this discrepancy.

Since we above (#569 (comment)) decided that it should only be generated if test-mode, i think test-config.cfg is better. Tell what it is, why it is there etc. But there may also be other uses, in that case we can rename it then. Since it is only used in test-mode today.

Didn't we use this for provision of config in our previous life @troglobit ?

@mattiaswal
Copy link
Contributor

Also:
#571 (comment)
is also valid here.

@axkar
Copy link
Collaborator Author

axkar commented Aug 22, 2024

Also: #571 (comment) is also valid here.

Added reference :)

mattiaswal
mattiaswal requested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@mattiaswal mattiaswal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor cosmetic stuff, the name issue is still there @troglobit should it be safe-config?

package/confd/tmpfiles.conf Outdated Show resolved Hide resolved
src/confd/share/test.d/Makefile.am Outdated Show resolved Hide resolved
@axkar axkar mentioned this pull request Aug 23, 2024
Closed
@axkar axkar requested a review from mattiaswal August 23, 2024 08:38
@troglobit
Copy link
Contributor

I second Mattias' comments and I'd also like to understand why the config is named test-config rather than safe-config, as described in #561. Please add motivation for this discrepancy.

Since we above (#569 (comment)) decided that it should only be generated if test-mode, i think test-config.cfg is better. Tell what it is, why it is there etc. But there may also be other uses, in that case we can rename it then. Since it is only used in test-mode today.

Didn't we use this for provision of config in our previous life @troglobit ?

OK, fair point. We can add a safe-config later when we have an actual use-case for it.

troglobit
troglobit approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this as long as Mattias' last comments are addressed.

@axkar
confd: generate test-config.cfg
fd0c9a9 
Currently, it's not possible to run infix tests from an external
project (based on infix) due to an incompatibility between the
configuration used in the tests (the default configuration
within the image generated by the external project) and the infix
base configuration expected by the test cases. Therefore, a simple
configuration specifically for testing purposes needs to be generated
within an image. This test-config should always be generated
but only loaded when the device is in test mode.

Part of issue kernelkit#568
@axkar
confd: load test-config when in test-mode
f19c867
@axkar
confd: minor cleanup
3043019 
- removed unused parameters in functions factory() and failure()
- renamed the functions
@axkar
confd: fix output directory for gen-version in gen_failure_cfg
595d4e7 
Fixes kernelkit#562
@mattiaswal mattiaswal merged commit 21274aa into kernelkit:main Aug 23, 2024
2 checks passed
@axkar axkar deleted the generate-test-cfg branch August 23, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troglobit troglobit troglobit approved these changes

@mattiaswal mattiaswal mattiaswal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axkar @mattiaswal @troglobit