Increase robustness of operational datastore #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify and add paragraph on how to select proto from test-sh. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
|
Ugly intermediate state of this PR, which still shows the general direction where I'd like to take this:
|
mattiaswal
requested changes
Aug 20, 2024
troglobit
force-pushed
the
test-reset-fail
branch
from
f577952
to
c770add
Compare
wkz
approved these changes
Aug 21, 2024
mattiaswal
approved these changes
Aug 22, 2024
troglobit
force-pushed
the
test-reset-fail
branch
from
180abb6
to
6a4ea6d
Compare
wkz
requested changes
Aug 22, 2024
These changes are intended to make yanger a bit more robust. Instead of bailing out on command errors, we now return empty string or object back to the callee in run_cmd() and run_json_cmd(). One example where yanger previously exited hard, and dragged with it the entire session, is when inspecting container status or when attempting to restart container instances which have yet to be created/stopped. Fixes #558 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
When unit tests run in CI we may not have a syslog daemon available, in such cases we set up a dummy handler. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
If a container has not yet stopped/started we may for proto RESTCONF get "invalid URI" result back for some container actions. With this change we allow the action to be retried up to three times before passing on the error. In tests on Qemu (x86_64) this happens very rarely and need at most one retry before succeeding. Verified by iterating the same basic test over night (9000+ iterations). Fixes #558 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Fixes #568 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit
force-pushed
the
test-reset-fail
branch
from
6a4ea6d
to
063c49c
Compare
Thank you! Your last suggestion btw, about allowing errors to bubble up, already uncovered a few missing test files and error handling in tests. Which @mattiaswal is working on right now 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR increases the robustness of the Infix
yangerhelper. Basically, instead of bailing out withsys.exit(1), causingstatdto fail and automatically cause a non-working operational datastore, we allow external commands to fail and then return empty objects/arrays to the respective data parsers.For example, asking the operational datastore for the status of a container before the container has been started properly should not b0rk the datastore, but rather return
Noneinformation. Same as if listing all containers.The test framework has also been made slightly more fault tolerant by adding a retry of container commands.
Fixes #558 and #568
Checklist
Tick relevant boxes, this PR is-a or has-a: