Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call make legal-info for releases to include in tarballs #67

Closed
3 tasks done
troglobit opened this issue Jun 30, 2023 · 1 comment · Fixed by #385
Closed
3 tasks done

Call make legal-info for releases to include in tarballs #67

troglobit opened this issue Jun 30, 2023 · 1 comment · Fixed by #385
Assignees
@troglobit @wkz
Labels
documentation Improvements or additions to documentation
Milestone
Infix v24.04

Comments

@troglobit
Copy link
Contributor

troglobit commented Jun 30, 2023 •
edited
Loading

Currently the build output has some things we need to look into:

WARNING: the Buildroot source code has not been saved
WARNING: toolchain-external-bootlin-2022.08-1: cannot save license (TOOLCHAIN_EXTERNAL_BOOTLIN_LICENSE_FILES not defined)
WARNING: linux-5.19.17: cannot save license (LINUX_LICENSE_FILES not defined)
WARNING: confd: sources not saved (local packages not handled)
WARNING: factory: sources not saved (local packages not handled)
WARNING: klinfix: sources not saved (local packages not handled)
WARNING: net: sources not saved (local packages not handled)
WARNING: localedef-2.36-81-g4f4d7a13edfd2fdc57c9d76e1fd6d017fb47550c: cannot save license (HOST_LOCALEDEF_LICENSE_FILES not defined)
Legal info produced in /home/jocke/src/infix/output/legal-info
make[1]: Leaving directory '/home/jocke/src/infix/buildroot'

Skipping local packages, the remaining issues to sort out are:

  • toolchain-external-bootlin-2022.08-1: cannot save license (TOOLCHAIN_EXTERNAL_BOOTLIN_LICENSE_FILES not defined)
  • linux-5.19.17: cannot save license (LINUX_LICENSE_FILES not defined)
  • localedef-2.36-81-g4f4d7a13edfd2fdc57c9d76e1fd6d017fb47550c: cannot save license (HOST_LOCALEDEF_LICENSE_FILES not defined)

From what I can tell, the kernel warning is because we're on a custom Linux version. The toolchain is prebuilt, so needs a follow-up with upstream, and so is the weird localdef warning.

After calling make legal-info, the entire output/legal-info directory should be uploaded as a separate versioned artifact.

This includes sources to everything that's not a local package, e.g.:

$ ls output/legal-info/sources/klish-tags_3.0.0/
0001-klishd-allow-all-users-of-group-wheel-to-connect.patch  klish-tags_3.0.0-br1.tar.gz
0002-tinyrl-Support-changing-default-keybindings.patch       series
@troglobit troglobit added the documentation Improvements or additions to documentation label Jun 30, 2023
@troglobit troglobit added this to the Infix v23.07 milestone Jun 30, 2023
@troglobit troglobit self-assigned this Jun 30, 2023
@troglobit troglobit modified the milestones: Infix v23.07, Infix v23.08 Jul 3, 2023
troglobit added a commit that referenced this issue Jul 3, 2023
@troglobit
package: add missing LICENSE and LICENSE_FILES to packages
dfe0a92 
For some reason, the `make license-info` target complained klinfix
needed a hash file, but not the other local repos.  Issue #67 tracks
adding license-info to releases, which will need some looking into,
for now this fixes the most glaring packaging oversights.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
rical pushed a commit that referenced this issue Jul 4, 2023
@troglobit @rical
package: add missing LICENSE and LICENSE_FILES to packages
6befbf6 
For some reason, the `make license-info` target complained klinfix
needed a hash file, but not the other local repos.  Issue #67 tracks
adding license-info to releases, which will need some looking into,
for now this fixes the most glaring packaging oversights.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit removed this from the Infix v23.08 milestone Aug 29, 2023
@troglobit troglobit mentioned this issue Aug 29, 2023
Closed
@troglobit troglobit added this to the Infix v24.03 milestone Feb 26, 2024
@troglobit
Copy link
Contributor Author

Retest this when we've rebased on Buildroot 2024.02 LTS. Should be included in v24.05, or earlier.

@troglobit troglobit linked a pull request Apr 9, 2024 that will close this issue
Drop Classic builds, fix local package licenses, add sbom #385
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@troglobit troglobit

@wkz wkz

Labels
documentation Improvements or additions to documentation
Projects
Infix & C:o
Status: Done
Milestone
Infix v24.04
Development

Successfully merging a pull request may close this issue.

Drop Classic builds, fix local package licenses, add sbom kernelkit/infix
2 participants
@troglobit @wkz