Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling IPv4 autoconf does not clean up 169.254/16 address on interface #638

Closed
troglobit opened this issue Sep 17, 2024 · 0 comments · Fixed by #639
Closed

Disabling IPv4 autoconf does not clean up 169.254/16 address on interface #638

troglobit opened this issue Sep 17, 2024 · 0 comments · Fixed by #639
Assignees
Labels
bug Something isn't working
Milestone

Comments

@troglobit
Copy link
Contributor

Current Behavior

While adding support for #628, the corresponding test was extended with a final pass which disables IPv4 autoconf to verify any 169.254/16 is removed.

Turns out this does not work, at all.

Expected Behavior

When disabling avahi-autoipd on an interface, it should clean up after itself as a final step.

Steps To Reproduce

.

Additional information

Inspecting the code it became evident that upon receiving SIGTERM, the daemon sends an internal message to call out to the /etc/avahi/avahi-autoipd.action script. However, immediately after sending that message the process closes all its open sockets and exits.

With a process monitor like Finit, the PID is collected and the entire remaining process group is reaped, leading the lingering dispatcher process to be stopped, sometimes even before having launched the script.

@troglobit troglobit added bug Something isn't working triage Pending investigation & classification (CCB) labels Sep 17, 2024
@troglobit troglobit self-assigned this Sep 17, 2024
@troglobit troglobit added this to the Infix v24.09 milestone Sep 17, 2024
@troglobit troglobit removed the triage Pending investigation & classification (CCB) label Sep 17, 2024
troglobit added a commit that referenced this issue Sep 17, 2024
Fixes #638

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Sep 17, 2024
 - Add check for specific 169.254/16 adddress (new feature)
 - Add check for disabling autoconf on interface (regression test #638)

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Sep 17, 2024
Fixes #638

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Sep 17, 2024
 - Add check for specific 169.254/16 adddress (new feature)
 - Add check for disabling autoconf on interface (regression test #638)

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Sep 24, 2024
Fixes #638

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Sep 24, 2024
 - Add check for specific 169.254/16 adddress (new feature)
 - Add check for disabling autoconf on interface (regression test #638)

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Sep 25, 2024
 - Add check for specific 169.254/16 adddress (new feature)
 - Add check for disabling autoconf on interface (regression test #638)

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Sep 25, 2024
Fixes #638

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Sep 25, 2024
 - Add check for specific 169.254/16 adddress (new feature)
 - Add check for disabling autoconf on interface (regression test #638)

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Sep 26, 2024
Fixes #638

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Sep 26, 2024
 - Add check for specific 169.254/16 adddress (new feature)
 - Add check for disabling autoconf on interface (regression test #638)

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Sep 26, 2024
 - Add check for specific 169.254/16 adddress (new feature)
 - Add check for disabling autoconf on interface (regression test #638)

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant