Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade netconf_client for tests and create a new docker image #390

Closed
mattiaswal opened this issue Apr 10, 2024 · 1 comment
Closed

Upgrade netconf_client for tests and create a new docker image #390

mattiaswal opened this issue Apr 10, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request test Regression test related
Milestone

Comments

@mattiaswal
Copy link
Contributor

mattiaswal commented Apr 10, 2024

This since they now have added get-data RPC which we have patched on our own.
infamy/netconf.py:

 def _get_data(self, xpath,as_xml=False):
        """Local member wrapper for netconf-client  RPC"""
        # pylint: disable=protected-access
        (raw, ele) = self.ncc._send_rpc(self._ncc_get_data_rpc(filter=xpath))
        data = NccGetDataReply(raw, ele)
        if(as_xml):
            return data

From netconf_client:

add support for the < get-data > command from RFC 8526
@mattiaswal mattiaswal added the test Regression test related label Apr 10, 2024
@troglobit
Copy link
Contributor

troglobit commented Apr 10, 2024

Ah great, finally. Thank you for looking into this!

@troglobit troglobit added the enhancement New feature or request label Apr 10, 2024
@troglobit troglobit added this to the Infix v24.10 milestone Sep 30, 2024
axkar added a commit that referenced this issue Oct 3, 2024
Refactor NETCONF functions (get_data) to accommodate the upgrade
in the netconf_client library within the Docker container image.

Fixes #390
axkar added a commit that referenced this issue Oct 3, 2024
Refactor NETCONF functions (get_data) to accommodate the upgrade
in the netconf_client library within the Docker container image.

Fixes #390
@axkar axkar closed this as completed in 4bed63d Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test Regression test related
Projects
Status: Done
Development

No branches or pull requests

3 participants