Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: track userid so shell command gets correct user #298

Closed
troglobit opened this issue Feb 2, 2024 · 1 comment · Fixed by #300
Closed

cli: track userid so shell command gets correct user #298

troglobit opened this issue Feb 2, 2024 · 1 comment · Fixed by #300
Assignees
@troglobit
Labels
enhancement New feature or request
Milestone
Infix v24.02

Comments

@troglobit
Copy link
Contributor

troglobit commented Feb 2, 2024 •
edited
Loading

Currently when logged in as admin in the CLI and executing the shell command we are suddenly root. Admittedly the CLI is full of holes and we've classified being logged in as !root being the same as root, but we could at least put on a bit of a show.

Minor, improvement of CLI UX.
@troglobit troglobit self-assigned this Feb 4, 2024
@troglobit troglobit added the enhancement New feature or request label Feb 4, 2024
@troglobit troglobit transferred this issue from kernelkit/klish Feb 4, 2024
@troglobit troglobit added this to the Infix v24.01 milestone Feb 4, 2024
@troglobit
Copy link
Contributor Author

Fix pending on container-basic branch.

@troglobit troglobit changed the title klish: track userid so shell command gets correct user cli: track userid so shell command gets correct user Feb 4, 2024
troglobit added a commit that referenced this issue Feb 4, 2024
@troglobit
src/klish-plugin-infix: new symbol shell@infix with user tracking
f7f6fce 
This patch adds a new klish symbol, shell@infix, which performs proper
droprivs before calling the configured shell.

Fix #298: track user id so shell command gets correct user

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Feb 10, 2024
@troglobit
src/klish-plugin-infix: new symbol shell@infix with user tracking
3135b06 
This patch adds a new klish symbol, shell@infix, which performs proper
droprivs before calling the configured shell.

Fix #298: track user id so shell command gets correct user

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit mentioned this issue Feb 10, 2024
Merged
12 tasks
troglobit added a commit that referenced this issue Feb 13, 2024
@troglobit
src/klish-plugin-infix: new symbol shell@infix with user tracking
ea404fe 
This patch adds a new klish symbol, shell@infix, which performs proper
droprivs before calling the configured shell.

Fix #298: track user id so shell command gets correct user

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Feb 13, 2024
@troglobit
src/klish-plugin-infix: new symbol shell@infix with user tracking
96b2409 
This patch adds a new klish symbol, shell@infix, which performs proper
droprivs before calling the configured shell.

Fix #298: track user id so shell command gets correct user

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit linked a pull request Feb 14, 2024 that will close this issue
Initial support for Docker containers #300
Merged
12 tasks
troglobit added a commit that referenced this issue Feb 22, 2024
@troglobit
src/klish-plugin-infix: new symbol shell@infix with user tracking
84b9c1a 
This patch adds a new klish symbol, shell@infix, which performs proper
droprivs before calling the configured shell.

Fix #298: track user id so shell command gets correct user

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Feb 24, 2024
@troglobit
src/klish-plugin-infix: new symbol shell@infix with user tracking
a066e4e 
This patch adds a new klish symbol, shell@infix, which performs proper
droprivs before calling the configured shell.

Fix #298: track user id so shell command gets correct user

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@troglobit troglobit

Labels
enhancement New feature or request
Projects
Infix & C:o
Status: Done
Milestone
Infix v24.02
Development

Successfully merging a pull request may close this issue.

Initial support for Docker containers kernelkit/infix
1 participant
@troglobit