Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop 'v' in version suffix in release artifacts #294

Closed
troglobit opened this issue Feb 2, 2024 · 1 comment · Fixed by #300
Closed

Drop 'v' in version suffix in release artifacts #294

troglobit opened this issue Feb 2, 2024 · 1 comment · Fixed by #300
Assignees
@troglobit
Milestone
Infix v24.02

Comments

@troglobit
Copy link
Contributor

troglobit commented Feb 2, 2024 •
edited
Loading

In 14be582 the missing 'v' in /etc/os-release was restored, but then accidentally also added to release artifact file names inside the tarballs.

Also, infix-$ARCH-disk.img and infix-$ARCH.img files are missing the version information. This may be by design, but worth double-checking while performing this task.
@troglobit troglobit added this to the Infix v24.01 milestone Feb 2, 2024
@troglobit troglobit assigned mattiaswal and troglobit and unassigned mattiaswal Feb 2, 2024
@troglobit
Copy link
Contributor Author

Fixed on container-basic branch.

troglobit added a commit that referenced this issue Feb 4, 2024
@troglobit
Fix #294: drop 'v' from version in filenames
8ecf4d1 
The files inside a release tarball, as well as the tarball name itself,
should not have the leading 'v', that's just for the tag.

Also, add -ver to GNS3 disk.img file as well.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Feb 10, 2024
@troglobit
Fix #294: drop 'v' from version in filenames
7fb7e5a 
The files inside a release tarball, as well as the tarball name itself,
should not have the leading 'v', that's just for the tag.

Also, add -ver to GNS3 disk.img file as well.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit mentioned this issue Feb 10, 2024
Merged
12 tasks
troglobit added a commit that referenced this issue Feb 13, 2024
@troglobit
Fix #294: drop 'v' from version in filenames
ee32be1 
The files inside a release tarball, as well as the tarball name itself,
should not have the leading 'v', that's just for the tag.

Also, add -ver to GNS3 disk.img file as well.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Feb 13, 2024
@troglobit
board/common: fix #294: drop 'v' from version in filenames
33085b0 
The files inside a release tarball, as well as the tarball name itself,
should not have the leading 'v', that's just for the tag.

Also, add -ver to GNS3 disk.img file as well.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit linked a pull request Feb 14, 2024 that will close this issue
Initial support for Docker containers #300
Merged
12 tasks
troglobit added a commit that referenced this issue Feb 22, 2024
@troglobit
board/common: fix #294: drop 'v' from version in filenames
d8e4297 
The files inside a release tarball, as well as the tarball name itself,
should not have the leading 'v', that's just for the tag.

Also, add -ver to GNS3 disk.img file as well.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Feb 24, 2024
@troglobit
board/common: fix #294: drop 'v' from version in filenames
8fe5b2f 
The files inside a release tarball, as well as the tarball name itself,
should not have the leading 'v', that's just for the tag.

Also, add -ver to GNS3 disk.img file as well.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@troglobit troglobit

Labels
None yet
Projects
Infix & C:o
Status: Done
Milestone
Infix v24.02
Development

Successfully merging a pull request may close this issue.

Initial support for Docker containers kernelkit/infix
2 participants
@troglobit @mattiaswal