-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting hostname is adding quotation marks to the DHCP request. #283
Comments
Nice catch! I'm guessing -x "hostname:infix-r2s-1" would work better, right? |
Because the hostname doesn't contain spaces, we don't need quotation marks. RFCs mandate that a hostname's labels may contain only the ASCII letters 'a' through 'z' (case-insensitive), the digits '0' through '9', and the hyphen. Hostname labels cannot begin or end with a hyphen. No other symbols, punctuation characters, or blank spaces are permitted.
|
Ah, of course! 😃👍 |
No need to guard the hostname option in quotes, it must not contain whitespace. If user configured more than one word, use first. Fixes #283 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
No need to guard the hostname option in quotes, it must not contain whitespace. If user configured more than one word, use first. Fixes #283 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Another fantastic fix for infix 👍 |
Manually setting the hostname in the DHCP request, and quotation marks are sent to the DHCP server.
Config
This can be seen in the udhcpc process.
udhcpc -f -p /run/dhcp-eth0.pid -t 10 -T 3 -A 10 -a1000 -S -R -x hostname:"infix-r2s-1" -i eth0 -V Infix v23.11.0-121-g051658d-dirty
The text was updated successfully, but these errors were encountered: