Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timm conversion for resnet #1814

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

sachinprasadhs
Copy link
Collaborator

@sachinprasadhs sachinprasadhs commented Sep 5, 2024

This is with the recent changes with resnet_vd which is breaking the timm conversion for resnet.
This fixes the naming convention with the latest changes and adds new arguments.

@mattdangerw mattdangerw changed the title Fix timm conversion for rersnet Fix timm conversion for resnet Sep 5, 2024
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This LGTM

@divyashreepathihalli divyashreepathihalli merged commit 49def20 into keras-hub Sep 5, 2024
17 checks passed
@sachinprasadhs sachinprasadhs deleted the sachinprasadhs-patch-1 branch September 5, 2024 19:57
mattdangerw pushed a commit to mattdangerw/keras-nlp that referenced this pull request Sep 10, 2024
mattdangerw pushed a commit that referenced this pull request Sep 10, 2024
mattdangerw pushed a commit that referenced this pull request Sep 11, 2024
mattdangerw pushed a commit that referenced this pull request Sep 13, 2024
mattdangerw pushed a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants