Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bounding Box Utils #1791

Merged

Conversation

sineeli
Copy link
Collaborator

@sineeli sineeli commented Aug 23, 2024

Added below utils for bounding boxes:

  • converters
  • to_dense
  • to_ragged

Future utils needed to be added:

  • iou
  • mask_invalid_detections
  • ensure_tensor
  • extra utils

@mattdangerw
Copy link
Member

Please run format!

@divyashreepathihalli this is the temporary move to keras-hub right?

Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is this is just a temporary home to get ourselves unblocked. If so, lgtm!

keras_nlp/src/bounding_box/converters_test.py Outdated Show resolved Hide resolved
keras_nlp/src/bounding_box/converters_test.py Outdated Show resolved Hide resolved
@sineeli
Copy link
Collaborator Author

sineeli commented Aug 23, 2024

Please run format!

I did run the format but seems the error is coming from api_gen. I even ran api_gen.sh but not sure what is causing the error.

Thanks for the review, I will resolve the issues mentioned.

Thanks!

@divyashreepathihalli
Copy link
Collaborator

looks like it needs shell/api_gen.sh, maybe try it again?

@divyashreepathihalli
Copy link
Collaborator

Please run format!

@divyashreepathihalli this is the temporary move to keras-hub right?

Yes! this should be temporary until they are added to keras core

@mattdangerw mattdangerw merged commit beae2f4 into keras-team:keras-hub Aug 28, 2024
7 checks passed
mattdangerw pushed a commit to mattdangerw/keras-nlp that referenced this pull request Sep 10, 2024
* Bounding box utils

* - Correct test cases

* - Remove hard tensorflow dtype

* - fix api gen

* - Fix import for test cases
- Use setup for converters test case

* - fix api_gen issue

* - FIx api gen

* - Fix api gen error

* - Correct test cases as per new api changes
mattdangerw pushed a commit that referenced this pull request Sep 11, 2024
* Bounding box utils

* - Correct test cases

* - Remove hard tensorflow dtype

* - fix api gen

* - Fix import for test cases
- Use setup for converters test case

* - fix api_gen issue

* - FIx api gen

* - Fix api gen error

* - Correct test cases as per new api changes
mattdangerw pushed a commit that referenced this pull request Sep 13, 2024
* Bounding box utils

* - Correct test cases

* - Remove hard tensorflow dtype

* - fix api gen

* - Fix import for test cases
- Use setup for converters test case

* - fix api_gen issue

* - FIx api gen

* - Fix api gen error

* - Correct test cases as per new api changes
mattdangerw pushed a commit that referenced this pull request Sep 17, 2024
* Bounding box utils

* - Correct test cases

* - Remove hard tensorflow dtype

* - fix api gen

* - Fix import for test cases
- Use setup for converters test case

* - fix api_gen issue

* - FIx api gen

* - Fix api gen error

* - Correct test cases as per new api changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants