Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VGG16 and VGG19 backbone #1737

Merged
merged 25 commits into from
Aug 8, 2024
Merged

Add VGG16 and VGG19 backbone #1737

merged 25 commits into from
Aug 8, 2024

Conversation

divyashreepathihalli
Copy link
Collaborator

No description provided.

@divyashreepathihalli divyashreepathihalli changed the title Agg Vgg16 backbone Agg VGG16 backbone Aug 5, 2024
@divyashreepathihalli divyashreepathihalli changed the title Agg VGG16 backbone Add VGG16 backbone Aug 5, 2024
@mattdangerw mattdangerw changed the base branch from master to keras-hub August 5, 2024 21:44
mattdangerw
mattdangerw reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some initial comments.

keras_nlp/src/models/vgg16/vgg16_backbone.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/vgg16_backbone.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/vgg16_backbone.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/vgg16_backbone.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/vgg16_backbone.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/vgg16_backbone.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/vgg16_backbone.py Outdated Show resolved Hide resolved
keras_nlp/src/tests/test_case.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/__init__.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/vgg16_backbone.py Outdated Show resolved Hide resolved
@mattdangerw mattdangerw mentioned this pull request Aug 6, 2024
Open
@divyashreepathihalli divyashreepathihalli mentioned this pull request Aug 6, 2024
Closed
mattdangerw
mattdangerw reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments. The big one remaining I see if the backbone parameters. VGG16 and VGG19 should not be different architectures. This might take some auditing of the current CV backbone parameters, so we can plan for consistency.

We also still need to figure out a preprocessing solution. But let's do that as a follow up.

keras_nlp/src/models/vgg16/vgg16_backbone.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/vgg16_backbone.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/vgg16_image_classifier.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/vgg16_image_classifier.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/vgg16_image_classifier.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/vgg16_image_classifier.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/vgg16_image_classifier.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg16/vgg16_image_classifier.py Outdated Show resolved Hide resolved
mattdangerw
mattdangerw reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Few more comments.

keras_nlp/src/models/vgg/vgg_backbone.py Show resolved Hide resolved
keras_nlp/src/models/vgg/vgg_backbone_test.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg/vgg_image_classifier_test.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg/vgg_image_classifier.py Outdated Show resolved Hide resolved
keras_nlp/src/models/vgg/vgg_image_classifier.py Outdated Show resolved Hide resolved
@mattdangerw
Copy link
Member

@divyashreepathihalli also make sure to run the format script! It keep failing in tests.

This was referenced Aug 8, 2024
Closed
Closed
Closed
@divyashreepathihalli divyashreepathihalli changed the title Add VGG16 backbone Add VGG16 and VGG19 backbone Aug 8, 2024
This was referenced Aug 8, 2024
Closed
Closed
Closed
Open
Closed
Open
Open
Open
Closed
Closed
Open
Open
Open
Open
Open
@james77777778 james77777778 mentioned this pull request Aug 9, 2024
Merged
divyashreepathihalli added a commit that referenced this pull request Aug 12, 2024
@divyashreepathihalli
Add VGG16 backbone (#1737)
a089a8b 
* Agg Vgg16 backbone

* update names

* update tests

* update test

* add image classifier

* incorporate review comments

* Update test case

* update backbone test

* add image classifier

* classifier cleanup

* code reformat

* add vgg16 image classifier

* make vgg generic

* update doc string

* update docstring

* add classifier test

* update tests

* update docstring

* address review comments

* code reformat

* update the configs

* address review comments

* fix task saved model test

* update init

* code reformatted
@divyashreepathihalli divyashreepathihalli mentioned this pull request Aug 16, 2024
Open
mattdangerw pushed a commit to mattdangerw/keras-nlp that referenced this pull request Sep 10, 2024
@divyashreepathihalli @mattdangerw
Add VGG16 backbone (keras-team#1737)
7a4bc47 
* Agg Vgg16 backbone

* update names

* update tests

* update test

* add image classifier

* incorporate review comments

* Update test case

* update backbone test

* add image classifier

* classifier cleanup

* code reformat

* add vgg16 image classifier

* make vgg generic

* update doc string

* update docstring

* add classifier test

* update tests

* update docstring

* address review comments

* code reformat

* update the configs

* address review comments

* fix task saved model test

* update init

* code reformatted
mattdangerw pushed a commit that referenced this pull request Sep 11, 2024
@divyashreepathihalli @mattdangerw
Add VGG16 backbone (#1737)
b681ea3 
* Agg Vgg16 backbone

* update names

* update tests

* update test

* add image classifier

* incorporate review comments

* Update test case

* update backbone test

* add image classifier

* classifier cleanup

* code reformat

* add vgg16 image classifier

* make vgg generic

* update doc string

* update docstring

* add classifier test

* update tests

* update docstring

* address review comments

* code reformat

* update the configs

* address review comments

* fix task saved model test

* update init

* code reformatted
mattdangerw pushed a commit that referenced this pull request Sep 13, 2024
@divyashreepathihalli @mattdangerw
Add VGG16 backbone (#1737)
edc74fa 
* Agg Vgg16 backbone

* update names

* update tests

* update test

* add image classifier

* incorporate review comments

* Update test case

* update backbone test

* add image classifier

* classifier cleanup

* code reformat

* add vgg16 image classifier

* make vgg generic

* update doc string

* update docstring

* add classifier test

* update tests

* update docstring

* address review comments

* code reformat

* update the configs

* address review comments

* fix task saved model test

* update init

* code reformatted
sineeli pushed a commit to sineeli/keras-hub that referenced this pull request Sep 16, 2024
@divyashreepathihalli @sineeli
Add VGG16 backbone (keras-team#1737)
c586321 
* Agg Vgg16 backbone

* update names

* update tests

* update test

* add image classifier

* incorporate review comments

* Update test case

* update backbone test

* add image classifier

* classifier cleanup

* code reformat

* add vgg16 image classifier

* make vgg generic

* update doc string

* update docstring

* add classifier test

* update tests

* update docstring

* address review comments

* code reformat

* update the configs

* address review comments

* fix task saved model test

* update init

* code reformatted
mattdangerw pushed a commit that referenced this pull request Sep 17, 2024
@divyashreepathihalli @mattdangerw
Add VGG16 backbone (#1737)
91a057e 
* Agg Vgg16 backbone

* update names

* update tests

* update test

* add image classifier

* incorporate review comments

* Update test case

* update backbone test

* add image classifier

* classifier cleanup

* code reformat

* add vgg16 image classifier

* make vgg generic

* update doc string

* update docstring

* add classifier test

* update tests

* update docstring

* address review comments

* code reformat

* update the configs

* address review comments

* fix task saved model test

* update init

* code reformatted
sineeli pushed a commit to sineeli/keras-hub that referenced this pull request Sep 19, 2024
@divyashreepathihalli @sineeli
Add VGG16 backbone (keras-team#1737)
7eeecbe 
* Agg Vgg16 backbone

* update names

* update tests

* update test

* add image classifier

* incorporate review comments

* Update test case

* update backbone test

* add image classifier

* classifier cleanup

* code reformat

* add vgg16 image classifier

* make vgg generic

* update doc string

* update docstring

* add classifier test

* update tests

* update docstring

* address review comments

* code reformat

* update the configs

* address review comments

* fix task saved model test

* update init

* code reformatted
sineeli pushed a commit to sineeli/keras-hub that referenced this pull request Sep 19, 2024
@divyashreepathihalli @sineeli
Add VGG16 backbone (keras-team#1737)
9d58a6e 
* Agg Vgg16 backbone

* update names

* update tests

* update test

* add image classifier

* incorporate review comments

* Update test case

* update backbone test

* add image classifier

* classifier cleanup

* code reformat

* add vgg16 image classifier

* make vgg generic

* update doc string

* update docstring

* add classifier test

* update tests

* update docstring

* address review comments

* code reformat

* update the configs

* address review comments

* fix task saved model test

* update init

* code reformatted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdangerw mattdangerw mattdangerw approved these changes

@fchollet fchollet Awaiting requested review from fchollet

Assignees
No one assigned
Labels
None yet
Projects
KerasHub
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divyashreepathihalli @mattdangerw @kokoro-team