Removed extra 'ip addr del' on the lo inteface

The 'post-up ip addr del 127.0.0.1/8 dev lo' was thought to be required when the loopback interface subnet mask was narrowed from /8 to /16. After testing first reboot, subsequent reboots, config reloads, and systemctl restart networking on linecards and supevisors (DNX VOQ chassis), this cleanup command does not appear to be required. As such, this change removes it as well as reverts sonic-net#15080.
kenneth-arista · Jun 14, 2023 · f43fcd2 · f43fcd2
1 parent bdc1d7a
commit f43fcd2
Show file tree

Hide file tree

Showing 19 changed files with 0 additions and 38 deletions.
diff --git a/files/image_config/interfaces/interfaces.j2 b/files/image_config/interfaces/interfaces.j2
@@ -25,8 +25,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 {% endblock loopback %}
 {% block mgmt_interface %}
 

diff --git a/src/sonic-config-engine/tests/sample_output/py2/interfaces b/src/sonic-config-engine/tests/sample_output/py2/interfaces
@@ -9,8 +9,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt b/src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt
@@ -9,8 +9,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt_ztp b/src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt_ztp
@@ -9,8 +9,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt_ztp_inband b/src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt_ztp_inband
@@ -9,8 +9,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt_ztp_inband_ip b/src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt_ztp_inband_ip
@@ -9,8 +9,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt_ztp_ip b/src/sonic-config-engine/tests/sample_output/py2/interfaces_nomgmt_ztp_ip
@@ -9,8 +9,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py2/mvrf_interfaces b/src/sonic-config-engine/tests/sample_output/py2/mvrf_interfaces
@@ -18,8 +18,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py2/mvrf_interfaces_nomgmt b/src/sonic-config-engine/tests/sample_output/py2/mvrf_interfaces_nomgmt
@@ -18,8 +18,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py2/two_mgmt_interfaces b/src/sonic-config-engine/tests/sample_output/py2/two_mgmt_interfaces
@@ -9,8 +9,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth1

diff --git a/src/sonic-config-engine/tests/sample_output/py3/interfaces b/src/sonic-config-engine/tests/sample_output/py3/interfaces
@@ -9,8 +9,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt b/src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt
@@ -9,8 +9,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt_ztp b/src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt_ztp
@@ -9,8 +9,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt_ztp_inband b/src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt_ztp_inband
@@ -9,8 +9,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt_ztp_inband_ip b/src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt_ztp_inband_ip
@@ -9,8 +9,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt_ztp_ip b/src/sonic-config-engine/tests/sample_output/py3/interfaces_nomgmt_ztp_ip
@@ -9,8 +9,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py3/mvrf_interfaces b/src/sonic-config-engine/tests/sample_output/py3/mvrf_interfaces
@@ -18,8 +18,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py3/mvrf_interfaces_nomgmt b/src/sonic-config-engine/tests/sample_output/py3/mvrf_interfaces_nomgmt
@@ -18,8 +18,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0

diff --git a/src/sonic-config-engine/tests/sample_output/py3/two_mgmt_interfaces b/src/sonic-config-engine/tests/sample_output/py3/two_mgmt_interfaces
@@ -9,8 +9,6 @@ iface lo inet loopback
    address 127.0.0.1
    netmask 255.255.0.0
    scope host
-   post-up ip addr del 127.0.0.1/8 dev lo
-   down ip addr add 127.0.0.1/8 dev lo
 
 # The management network interface
 auto eth0