Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve GitHub community standards #698

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

sheerlox
Copy link
Collaborator

@sheerlox sheerlox commented Sep 26, 2023

Description

In order to guide potential new contributors, this PR improves GitHub community standards thanks to the following changes:

  • add CODE_OF_CONDUCT.md, CONTRIBUTING.md
  • update issue templates

Related Issue

Fixes #696.

@sheerlox sheerlox self-assigned this Sep 26, 2023
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@intcreator intcreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! I found a couple issues with links that should be addressed is all

@sheerlox
Copy link
Collaborator Author

@intcreator I have addressed all of your comments! Thank you for reviewing that PR closely with your keen sight 😉

@intcreator
Copy link
Collaborator

approved!

@sheerlox sheerlox merged commit 6bdef77 into kelektiv:main Sep 26, 2023
11 checks passed
@sheerlox sheerlox deleted the chore/improve-community-standards branch September 26, 2023 19:11
sheerlox added a commit to sheerlox/node-cron that referenced this pull request Sep 27, 2023
ncb000gt pushed a commit that referenced this pull request Sep 29, 2023
## [3.0.0-beta.9](v3.0.0-beta.8...v3.0.0-beta.9) (2023-09-29)

### ⚠ Breaking changes

* `utcOffset` parameter no longer accepts a string
* `utcOffset` values between -60 and 60 are no longer
treated as hours
* providing both `timeZone` and `utcOffset` parameters
now throws an error

### ✨ Features

* rework utcOffset parameter ([#699](#699)) ([72d3d36](72d3d36))

### ♻️ Chores

* improve GitHub community standards ([#698](#698)) ([6bdef77](6bdef77))

### 💎 Styles

* fix linting issues ([b48c1b2](b48c1b2))
@ncb000gt
Copy link
Member

🎉 This PR is included in version 3.0.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

sheerlox added a commit to sheerlox/node-cron that referenced this pull request Sep 29, 2023
sheerlox added a commit to sheerlox/node-cron that referenced this pull request Sep 29, 2023
ncb000gt pushed a commit that referenced this pull request Sep 30, 2023
## [3.0.0](v2.4.4...v3.0.0) (2023-09-30)

### ⚠ Breaking changes

* `utcOffset` parameter no longer accepts a string
* `utcOffset` values between -60 and 60 are no longer
treated as hours
* providing both `timeZone` and `utcOffset` parameters
now throws an error
* removed `cron.job()` method in favor of `new CronJob(...args)` /
`CronJob.from(argsObject)`
* removed `cron.time()` method in favor of `new CronTime()`
* `CronJob`: constructor no longer accepts an object as its first and
only params. Use `CronJob.from(argsObject)` instead.
* `CronJob`: callbacks are now called in the order they were registered
* return empty array from nextDates when called without argument (#519)
* UNIX standard alignments (#667)

### ✨ Features

* expose useful types ([737b344](737b344))
* rework utcOffset parameter ([#699](#699)) ([671e933](671e933))
* UNIX standard alignments ([#667](#667)) ([ff615f1](ff615f1))

### 🐛 Bug Fixes

* return empty array from nextDates when called without argument ([#519](#519)) ([c2891ba](c2891ba))

### 📦 Code Refactoring

* migrate to TypeScript ([#694](#694)) ([2d77894](2d77894))

### 📚 Documentation

* **readme:** remove outdated informations ([#695](#695)) ([b5ceaf1](b5ceaf1))

### 🚨 Tests

* update new test for cron standard alignments ([4a406c1](4a406c1))

### ♻️ Chores

* improve GitHub community standards ([#698](#698)) ([6bdef77](6bdef77))
* update contributors list ([dab3d69](dab3d69))

### 💎 Styles

* fix linting issues ([47e665f](47e665f))
@ncb000gt
Copy link
Member

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sheerlox sheerlox added type:chore Other changes that don't modify src or test files and removed released on @beta labels Sep 30, 2023
@sheerlox sheerlox removed their assignment Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type:chore Other changes that don't modify src or test files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve the GitHub "Community Standards" for this repository
3 participants