fix!: return empty array from nextDates when called without argument #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## beta #519 +/- ##
=======================================
Coverage ? 92.35%
=======================================
Files ? 3
Lines ? 353
Branches ? 103
=======================================
Hits ? 326
Misses ? 26
Partials ? 1 ☔ View full report in Codecov by Sentry. |
sheerlox
changed the title
sheerlox
force-pushed
the
fix-next-dates
branch
from
4d2932f
to
58b8b10
Compare
sheerlox
force-pushed
the
fix-next-dates
branch
from
a916535
to
dfb89ae
Compare
sheerlox
changed the title
34 tasks
intcreator
approved these changes
Aug 15, 2023
|
Thank you for your work on this @oxidia! 🚀 |
|
🎉 This PR is included in version 3.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sheerlox
pushed a commit
that referenced
this pull request
Sep 27, 2023
sheerlox
pushed a commit
that referenced
this pull request
Sep 27, 2023
sheerlox
pushed a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 27, 2023
sheerlox
pushed a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 27, 2023
sheerlox
pushed a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 29, 2023
sheerlox
pushed a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 29, 2023
sheerlox
pushed a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 29, 2023
sheerlox
pushed a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 29, 2023
Merged
sheerlox
pushed a commit
that referenced
this pull request
Sep 30, 2023
ncb000gt
pushed a commit
that referenced
this pull request
Sep 30, 2023
## [3.0.0](v2.4.4...v3.0.0) (2023-09-30) ### ⚠ Breaking changes * `utcOffset` parameter no longer accepts a string * `utcOffset` values between -60 and 60 are no longer treated as hours * providing both `timeZone` and `utcOffset` parameters now throws an error * removed `cron.job()` method in favor of `new CronJob(...args)` / `CronJob.from(argsObject)` * removed `cron.time()` method in favor of `new CronTime()` * `CronJob`: constructor no longer accepts an object as its first and only params. Use `CronJob.from(argsObject)` instead. * `CronJob`: callbacks are now called in the order they were registered * return empty array from nextDates when called without argument (#519) * UNIX standard alignments (#667) ### ✨ Features * expose useful types ([737b344](737b344)) * rework utcOffset parameter ([#699](#699)) ([671e933](671e933)) * UNIX standard alignments ([#667](#667)) ([ff615f1](ff615f1)) ### 🐛 Bug Fixes * return empty array from nextDates when called without argument ([#519](#519)) ([c2891ba](c2891ba)) ### 📦 Code Refactoring * migrate to TypeScript ([#694](#694)) ([2d77894](2d77894)) ### 📚 Documentation * **readme:** remove outdated informations ([#695](#695)) ([b5ceaf1](b5ceaf1)) ### 🚨 Tests * update new test for cron standard alignments ([4a406c1](4a406c1)) ### ♻️ Chores * improve GitHub community standards ([#698](#698)) ([6bdef77](6bdef77)) * update contributors list ([dab3d69](dab3d69)) ### 💎 Styles * fix linting issues ([47e665f](47e665f))
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
nextDatesreturn an array(as described in the README.md) even if it's called without an argument(in this case an empty array)nextDatedescription in the README.mdCurrent behaviour
nextDatesreturn a moment object, if it's called without an argumentDetails
nextDatesfunction in the READM.md