feat: add no-regexp-v-flag (and bump to ES2024)
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - fix: ensures no-hashbang-comment rule is in TS 2023 - docs: remove unneeded backticks in no-regexp-s-flag rule docs
keithamus
reviewed
Jul 24, 2024
|
|
||
| let dotAll = `/[\0-\uFFFF]/` | ||
| let dotAll = /[\0-\uFFFF]/ | ||
| ``` | ||
|
|
||
| If you are using it in combination with the `u` flag then you may adjust the pattern: |
There was a problem hiding this comment.
If we're coming back to this, it might be good to offer more detail on how workarounds function. This is a little unclear (I know it's not your writing but if you're happy to improve it that would be great!). Can be done here or in a follow up.
There was a problem hiding this comment.
Sorry, I'm not so clear on how to improve it.
There was a problem hiding this comment.
It's fine we can follow up on it later.
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
|
Good doc suggestions. Applied... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add
no-regexp-v-flag(and bump to ES2024)Also:
Realized there was ES2024 and ES2025 too.