Option to add multiple schemas #191
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| final String[] representation, final boolean targetOnly, | ||
| final String sipID, final String[] ancestors, final String[] documentation, final String softwareVersion, | ||
| final String path, final String submitterAgentName, final String submitterAgentID, final String checksum) | ||
| final String[] representation, String[] metadataSchema, final boolean targetOnly, |
There was a problem hiding this comment.
Parameter metadataSchema should be final.
| final String[] representation, final boolean targetOnly, | ||
| final String sipID, final String[] ancestors, final String[] documentation, final String softwareVersion, | ||
| final String path, final String submitterAgentName, final String submitterAgentID, final String checksum) | ||
| final String[] representation, String[] metadataSchema, final boolean targetOnly, |
There was a problem hiding this comment.
Variable 'metadataSchema' should be declared final.
| final String sipID, final String[] ancestors, final String[] documentation, final String softwareVersion, | ||
| final String path, final String submitterAgentName, final String submitterAgentID, final String checksum) | ||
| final String[] representation, String[] metadataSchema, final boolean targetOnly, | ||
| final String sipID, final String[] ancestors, final String[] documentation, final String softwareVersion, |
There was a problem hiding this comment.
Line is longer than 120 characters (found 141).
| final String path, final String submitterAgentName, final String submitterAgentID, final String checksum) | ||
| final String[] representation, String[] metadataSchema, final boolean targetOnly, | ||
| final String sipID, final String[] ancestors, final String[] documentation, final String softwareVersion, | ||
| final String path, final String submitterAgentName, final String submitterAgentID, final String checksum) |
There was a problem hiding this comment.
Line is longer than 120 characters (found 141).
| @@ -214,6 +209,11 @@ public static Path createEARK2SIP(final String[] metadata, | |||
| CLIUtils.printErrors(System.out, "Cannot add metadata to the SIP."); | |||
| } | |||
| } | |||
| if (metadataSchema != null){ | |||
There was a problem hiding this comment.
'{' is not preceded with whitespace.
| @@ -214,6 +209,11 @@ public static Path createEARK2SIP(final String[] metadata, | |||
| CLIUtils.printErrors(System.out, "Cannot add metadata to the SIP."); | |||
| } | |||
| } | |||
| if (metadataSchema != null){ | |||
| for(String schema : metadataSchema){ | |||
There was a problem hiding this comment.
'for' is not followed by whitespace.
| @@ -214,6 +209,11 @@ public static Path createEARK2SIP(final String[] metadata, | |||
| CLIUtils.printErrors(System.out, "Cannot add metadata to the SIP."); | |||
| } | |||
| } | |||
| if (metadataSchema != null){ | |||
| for(String schema : metadataSchema){ | |||
There was a problem hiding this comment.
'{' is not preceded with whitespace.
No description provided.