Fix: find_element(): No value found for key #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftheirs
force-pushed
the
ft/fix_block_164333
branch
from
8f10973
to
31d3f25
Compare
ftheirs
force-pushed
the
ft/fix_block_164333
branch
from
31d3f25
to
920f997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Some blocks contain a Declare and in the same block a Deploy transaction. This condition triggers an error in
find_elementhint from cairo-vmSolution:
The solution consists in setting two hash maps that are used by snos with the correct information.
For declare transactions:
class_hash_to_compiled_class_hash: HashMap<ClassHash, CompiledClassHash>needs to be initialized with Zero for all new classesFor deploy transactions:
compiled_classes: HashMap<CompiledClassHash, GenericCasmContractClass>needs to be set with the compiled_class_hash from declared class and the corresponding binary.Issue Number: #376
Closes #376
Type
Description
Breaking changes?