Added tests for fill_holes_in_rc96_segment and search_sorted_optimistic hints
#375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsasari
force-pushed
the
shams-hints-tests
branch
from
8a0fb4d
to
6574ec9
Compare
notlesh
reviewed
Sep 19, 2024
notlesh
reviewed
Sep 19, 2024
notlesh
reviewed
Sep 19, 2024
notlesh
reviewed
Sep 19, 2024
notlesh
reviewed
Sep 19, 2024
notlesh
requested changes
Sep 19, 2024
…istic` hints `search_sorted_optimistic` was previously called `find_element` and was renamed to match the Cairo function it's called from, since there are three variations of very similar hint code.
shamsasari
force-pushed
the
shams-hints-tests
branch
2 times, most recently
from
4ad1966
to
d2d86d1
Compare
shamsasari
commented
Sep 19, 2024
|
PTAL |
shamsasari
force-pushed
the
shams-hints-tests
branch
from
d2d86d1
to
390bcd9
Compare
notlesh
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search_sorted_optimisticwas previously calledfind_elementand has been renamed to match the correct Cairo function it's called from, since there are three variations of very similar hint code.