Implemented test for pricing utils. waiting for #417 to be completed #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ametel01
force-pushed
the
Improvetestsofpricing_utils
branch
2 times, most recently
from
e142125
to
1f99a4f
Compare
|
Hey ! Thanks but @StarkFishinator already had an ongoing PR on this here and he was assigned on the issue so we'll leave him the priority for the 'apply_exponent_factor' part |
|
I'll remove the changes in utils leaving only the tests, and draft this PR until utils are completed. |
ametel01
force-pushed
the
Improvetestsofpricing_utils
branch
from
4857cac
to
0fcfe82
Compare
ametel01
changed the title
cubit Library for apply_exponent_factor() and Test Enhancements"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type:
Current Behavior:
The function
apply_exponent_factor()was missing, and no tests were available forapply_impact_factor().Resolves: #494
Updated Behaviour:
Testing parameters mirror those found in GMX's test.
Breaking Change Introduced?
No