Add GML and GraphML NetworkX datasets #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrugman
force-pushed
the
feat-networkx-datasets
branch
4 times, most recently
from
d646021
to
4d393f8
Compare
antonymilne
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
This is awesome work, thank you very much @sbrugman for your contribution! Just a few minor comments, but I think this is a great improvement. Thank you!
sbrugman
force-pushed
the
feat-networkx-datasets
branch
from
4d393f8
to
814d932
Compare
|
Thanks for the reviews @AntonyMilneQB and @MerelTheisenQB ! I've updated the branch to incorporate the suggestions. |
idanov
changed the title
idanov
approved these changes
Sep 9, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces feature described in #828
Development notes
Follow up from #830 with comments processed, based on the lastest development branch. Thanks @ignacioparicio for reviewing!
Omitted GPickleDataSet as GPickle is deprecated in NetworkX and will be removed in the third version (ref).
Included GraphML in addition to GML. Some tools prefer GraphML as it's able to perfectly preserve internal property maps (ref).
Checklist
RELEASE.mdfileNotice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.