Add warning for catch-all patterns [dataset factories] #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
merelcht
reviewed
Jul 6, 2023
kedro/io/data_catalog.py
Outdated
| @@ -386,6 +386,13 @@ def _get_dataset( | |||
| self._load_versions.get(data_set_name), | |||
| self._save_version, | |||
| ) | |||
| if self._specificity(matched_pattern) == 0: | |||
| self._logger.warning( | |||
| "The dataset '%s' is using the catch-all pattern '%s'", | |||
There was a problem hiding this comment.
I think it would be good to provide a bit more info on what that means. Either a link to a section in the docs which explains what the catch-all pattern is, or some more text here explaining that it overrides the default MemoryDataset creation.
There was a problem hiding this comment.
Should this be Info or Warning log do you think?
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
noklam
approved these changes
Jul 6, 2023
merelcht
approved these changes
Jul 6, 2023
ankatiyar
merged commit bdc953d
into
feature/dataset-factories-for-catalog
1 of 3 checks passed
ankatiyar
added a commit
that referenced
this pull request
Jul 6, 2023
* Cleaned up and up to date version of dataset factories code Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com> * Add some simple tests Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com> * Add parsing rules Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Refactor Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add some tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add unit tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Fix test + refactor runner Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add comments + update specificity fn Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update function names Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update test Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Release notes + update resume scenario fix Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert change to suggest resume scenario Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update tests DataSet->Dataset Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Small refactor + move parsing rules to a new fn Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Fix problem with load_version + refactor Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * linting + small fix _get_datasets Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Remove check for existence Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add updated tests + Release notes Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * change classmethod to staticmethod for _match_patterns Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add test for layer Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Minor change from code review Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Remove type conversion Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add warning for catch-all patterns [dataset factories] (#2774) * Add warning for catch-all patterns Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update warning message Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Co-authored-by: Merel Theisen <merel.theisen@quantumblack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #2760
Development notes
Since this is a small change, I thought I'll add it to the main Dataset Factories PR #2635.
Throw a warning at the first instance that the dataset is used (and added to the catalog)
Checklist
RELEASE.mdfile