-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support OAuth for pulsar scaler #4709
support OAuth for pulsar scaler #4709
Conversation
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
91b3ccb
to
8933a45
Compare
Signed-off-by: Ming Meng <ming.meng@collibra.com>
8933a45
to
02c5f58
Compare
/run-e2e pulsar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, my only concern is about exposing auth data in the trigger metadata, see: kedacore/keda-docs#1161 (review)
Signed-off-by: Ming Meng <ming.meng@collibra.com>
d8756cd
to
53b26ad
Compare
Signed-off-by: Ming Meng <101287520+mingmcb@users.noreply.github.com> Signed-off-by: Ming Meng <ming.meng@collibra.com>
53b26ad
to
9dca8af
Compare
/run-e2e pulsar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the format for scope
Signed-off-by: Ming Meng <ming.meng@collibra.com>
Signed-off-by: Ming Meng <101287520+mingmcb@users.noreply.github.com>
Signed-off-by: Ming Meng <101287520+mingmcb@users.noreply.github.com>
c513f2a
to
1f5f9cb
Compare
Signed-off-by: Ming Meng <ming.meng@collibra.com>
1f5f9cb
to
1f809b9
Compare
This is great, there's also a proposal for a generic OAuth support that I like. I wonder if we can go this direction as well for Pulsar? #4694 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, minor stuff.
/run-e2e pulsar |
@kedacore/keda-core-contributors WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mingmcb do you think you can address the review comments? We can proceed and merge the PR then.
We are back after a summer break
3c805bf
to
c414866
Compare
Signed-off-by: Ming Meng <ming.meng@collibra.com>
c414866
to
0472c41
Compare
/run-e2e pulsar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: anton.lysina <alysina@gmail.com>
support OAuth for pulsar scaler
Checklist
Relates to #4700
Relates to kedacore/keda-docs#1161