Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose Prom Metrics also when getting ScaledObject State #4115

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

zroubalik
Copy link
Member

Signed-off-by: Zbynek Roubalik zroubalik@gmail.com

I have also taken the chance and refactored the code a little bit, to be more consistent and move the ScaledObject scaling related logic to scaler_handler.go and keep the scalers_cache.go just around the cache.

Checklist

Fixes #4075

@zroubalik zroubalik requested a review from a team as a code owner January 16, 2023 16:08
@zroubalik
Copy link
Member Author

zroubalik commented Jan 16, 2023

/run-e2e internals*
Update: You can check the progress here

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik
Copy link
Member Author

zroubalik commented Jan 16, 2023

/run-e2e internals*
Update: You can check the progress here

JorTurFer
JorTurFer previously approved these changes Jan 16, 2023
@JorTurFer JorTurFer dismissed their stale review January 16, 2023 17:00

I need to review it again

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a small nit inline

pkg/scaling/cache/scalers_cache.go Show resolved Hide resolved
@zroubalik zroubalik merged commit 29b8af5 into kedacore:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus' metrics in the operator are only exposed when the metrics server requests the metrics
2 participants