Enhance azure data explorer scaler metric name with trigger.metadata.metricName #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metricName Signed-off-by: Ying Liu <lying@microsoft.com>
cdlliuy
force-pushed
the
ying/update_azure_data_explorer_metricname
branch
from
4a0e2ee
to
f1bca18
Compare
|
add @v-shenoy for review |
v-shenoy
reviewed
Aug 24, 2022
| @@ -118,7 +118,13 @@ func parseAzureDataExplorerMetadata(config *ScalerConfig, logger logr.Logger) (* | |||
| } | |||
|
|
|||
| // Generate metricName. | |||
| metadata.MetricName = GenerateMetricNameWithIndex(config.ScalerIndex, kedautil.NormalizeString(fmt.Sprintf("%s-%s", adxName, metadata.DatabaseName))) | |||
| metadataName, _ := getParameterFromConfig(config, "metricName", false) | |||
There was a problem hiding this comment.
Suggested change
| metadataName, _ := getParameterFromConfig(config, "metricName", false) | |
| metricName, err := getParameterFromConfig(config, "metricName", false) |
There was a problem hiding this comment.
@v-shenoy , updated in another approach. please help to review again.
|
Hmm, there has been some discussion regarding the need for this parameter - #3182 @JorTurFer @zroubalik can give their thoughts about this. |
|
Let's discuss this in the issue, I wrote a comment there |
Signed-off-by: Ying Liu <lying@microsoft.com>
|
close this PR since the solution is changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to address #3588